public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

mcp: use sentinel-terminated strings for tool params

Browse Source
This commit is contained in:
Adrià Arrufat
2026-03-01 20:58:00 +09:00
parent fcad67a854
commit 01798ed7f8
1 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/mcp/tools.zig
View File

@@ -21,19 +21,19 @@ pub fn handleList(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
} }
const GotoParams = struct { const GotoParams = struct {
url: []const u8, url: [:0]const u8,
}; };
const SearchParams = struct { const SearchParams = struct {
text: []const u8, text: [:0]const u8,
}; };
const EvaluateParams = struct { const EvaluateParams = struct {
script: []const u8, script: [:0]const u8,
}; };
const OverParams = struct { const OverParams = struct {
result: []const u8, result: [:0]const u8,
}; };
const ToolStreamingText = struct { const ToolStreamingText = struct {
@@ -101,7 +101,7 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
return sendError(server, req.id.?, -32602, "Invalid arguments for goto"); return sendError(server, req.id.?, -32602, "Invalid arguments for goto");
}; };
performGoto(server, arena, args.url) catch { performGoto(server, args.url) catch {
return sendError(server, req.id.?, -32603, "Internal error during navigation"); return sendError(server, req.id.?, -32603, "Internal error during navigation");
}; };
@@ -120,11 +120,11 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
component.formatQuery(&url_aw.writer) catch { component.formatQuery(&url_aw.writer) catch {
return sendError(server, req.id.?, -32603, "Internal error formatting query"); return sendError(server, req.id.?, -32603, "Internal error formatting query");
}; };
const url = std.fmt.allocPrint(arena, "https://duckduckgo.com/?q={s}", .{url_aw.written()}) catch { const url = std.fmt.allocPrintSentinel(arena, "https://duckduckgo.com/?q={s}", .{url_aw.written()}, 0) catch {
return sendError(server, req.id.?, -32603, "Internal error formatting URL"); return sendError(server, req.id.?, -32603, "Internal error formatting URL");
}; };
performGoto(server, arena, url) catch { performGoto(server, url) catch {
return sendError(server, req.id.?, -32603, "Internal error during search navigation"); return sendError(server, req.id.?, -32603, "Internal error during search navigation");
}; };
@@ -132,12 +132,12 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
try sendResult(server, req.id.?, .{ .content = &content }); try sendResult(server, req.id.?, .{ .content = &content });
} else if (std.mem.eql(u8, call_params.name, "markdown")) { } else if (std.mem.eql(u8, call_params.name, "markdown")) {
const MarkdownParams = struct { const MarkdownParams = struct {
url: ?[]const u8 = null, url: ?[:0]const u8 = null,
}; };
if (call_params.arguments) |args_raw| { if (call_params.arguments) |args_raw| {
if (std.json.parseFromValueLeaky(MarkdownParams, arena, args_raw, .{ .ignore_unknown_fields = true })) |args| { if (std.json.parseFromValueLeaky(MarkdownParams, arena, args_raw, .{ .ignore_unknown_fields = true })) |args| {
if (args.url) |u| { if (args.url) |u| {
performGoto(server, arena, u) catch { performGoto(server, u) catch {
return sendError(server, req.id.?, -32603, "Internal error during navigation"); return sendError(server, req.id.?, -32603, "Internal error during navigation");
}; };
} }
@@ -155,12 +155,12 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
try sendResult(server, req.id.?, result); try sendResult(server, req.id.?, result);
} else if (std.mem.eql(u8, call_params.name, "links")) { } else if (std.mem.eql(u8, call_params.name, "links")) {
const LinksParams = struct { const LinksParams = struct {
url: ?[]const u8 = null, url: ?[:0]const u8 = null,
}; };
if (call_params.arguments) |args_raw| { if (call_params.arguments) |args_raw| {
if (std.json.parseFromValueLeaky(LinksParams, arena, args_raw, .{ .ignore_unknown_fields = true })) |args| { if (std.json.parseFromValueLeaky(LinksParams, arena, args_raw, .{ .ignore_unknown_fields = true })) |args| {
if (args.url) |u| { if (args.url) |u| {
performGoto(server, arena, u) catch { performGoto(server, u) catch {
return sendError(server, req.id.?, -32603, "Internal error during navigation"); return sendError(server, req.id.?, -32603, "Internal error during navigation");
}; };
} }
@@ -182,8 +182,8 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
} }
const EvaluateParamsEx = struct { const EvaluateParamsEx = struct {
script: []const u8, script: [:0]const u8,
url: ?[]const u8 = null, url: ?[:0]const u8 = null,
}; };
const args = std.json.parseFromValueLeaky(EvaluateParamsEx, arena, call_params.arguments.?, .{ .ignore_unknown_fields = true }) catch { const args = std.json.parseFromValueLeaky(EvaluateParamsEx, arena, call_params.arguments.?, .{ .ignore_unknown_fields = true }) catch {
@@ -191,7 +191,7 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
}; };
if (args.url) |url| { if (args.url) |url| {
performGoto(server, arena, url) catch { performGoto(server, url) catch {
return sendError(server, req.id.?, -32603, "Internal error during navigation"); return sendError(server, req.id.?, -32603, "Internal error during navigation");
}; };
} }
@@ -224,9 +224,8 @@ pub fn handleCall(server: *Server, arena: std.mem.Allocator, req: protocol.Reque
} }
} }
fn performGoto(server: *Server, arena: std.mem.Allocator, url: []const u8) !void { fn performGoto(server: *Server, url: [:0]const u8) !void {
const url_z = try arena.dupeZ(u8, url); _ = server.page.navigate(url, .{
_ = server.page.navigate(url_z, .{
.reason = .address_bar, .reason = .address_bar,
.kind = .{ .push = null }, .kind = .{ .push = null },
}) catch { }) catch {