From 036f808ec6b988414052ee1e8458f7fc583fe8cd Mon Sep 17 00:00:00 2001
From: Pierre Tachoire <pierre@lightpanda.io>
Date: Wed, 27 Aug 2025 17:30:06 +0200
Subject: [PATCH] page: ensure page navigate events order

---
 src/browser/page.zig | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/browser/page.zig b/src/browser/page.zig
index b0ffbaf8..6bf5239f 100644
--- a/src/browser/page.zig
+++ b/src/browser/page.zig
@@ -520,6 +520,14 @@ pub const Page = struct {
         if (opts.header) |hdr| try headers.add(hdr);
         try self.requestCookie(.{ .is_navigation = true }).headersForRequest(self.arena, owned_url, &headers);
 
+        // We dispatch page_navigate event before sending the request.
+        // It ensures the event page_navigated is not dispatched before this one.
+        self.session.browser.notification.dispatch(.page_navigate, &.{
+            .opts = opts,
+            .url = owned_url,
+            .timestamp = timestamp(),
+        });
+
         self.http_client.request(.{
             .ctx = self,
             .url = owned_url,
@@ -536,12 +544,6 @@ pub const Page = struct {
             log.err(.http, "navigate request", .{ .url = owned_url, .err = err });
             return err;
         };
-
-        self.session.browser.notification.dispatch(.page_navigate, &.{
-            .opts = opts,
-            .url = owned_url,
-            .timestamp = timestamp(),
-        });
     }
 
     pub fn setCurrentScript(self: *Page, script: ?*parser.Script) !void {