public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1186 from lightpanda-io/defer-module

Browse Source 
module scripts are deferred by default
This commit is contained in:
Karl Seguin
2025-10-28 18:36:54 +08:00
committed by GitHub
parent f7abf0956f 52fc2c365f
commit 07e603ecda
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/browser/ScriptManager.zig
View File

@@ -228,9 +228,9 @@ pub fn addFromElement(self: *ScriptManager, element: *parser.Element, comptime c
if (source == .@"inline") { if (source == .@"inline") {
// if we're here, it means that we have pending scripts (i.e. self.scripts // if we're here, it means that we have pending scripts (i.e. self.scripts
// is not empty). Because the script is inline, it's complete/ready, but // is not empty). Because the script is inline, it's complete/ready, but
// we need to process them in order // we need to process them in order.
pending_script.complete = true; pending_script.complete = true;
self.scripts.append(&pending_script.node); pending_script.getList().append(&pending_script.node);
return; return;
} else { } else {
log.debug(.http, "script queue", .{ log.debug(.http, "script queue", .{
@@ -651,6 +651,12 @@ pub const PendingScript = struct {
return &self.manager.deferreds; return &self.manager.deferreds;
} }
// Module scripts are deferred by default.
// https://v8.dev/features/modules#defer
if (script.kind == .module) {
return &self.manager.deferreds;
}
return &self.manager.scripts; return &self.manager.scripts;
} }
}; };