public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #181 from lightpanda-io/xhr-event-delay

Browse Source 
xhr: respect 50ms min delay between two progress events
This commit is contained in:
Pierre Tachoire
2024-02-27 17:54:50 +01:00
committed by GitHub
parent 5a70db1322 5439a37d25
commit 08e2365d75
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/xhr/xhr.zig
View File

@@ -165,6 +165,8 @@ pub const XMLHttpRequest = struct {
payload: ?[]const u8 = null, payload: ?[]const u8 = null,
const min_delay: u64 = 50000000; // 50ms
pub fn constructor(alloc: std.mem.Allocator, loop: *Loop) !XMLHttpRequest { pub fn constructor(alloc: std.mem.Allocator, loop: *Loop) !XMLHttpRequest {
return .{ return .{
.alloc = alloc, .alloc = alloc,
@@ -298,6 +300,7 @@ pub const XMLHttpRequest = struct {
typ: []const u8, typ: []const u8,
opts: ProgressEvent.EventInit, opts: ProgressEvent.EventInit,
) void { ) void {
log.debug("dispatch progress event: {s}", .{typ});
var evt = ProgressEvent.constructor(typ, .{ var evt = ProgressEvent.constructor(typ, .{
// https://xhr.spec.whatwg.org/#firing-events-using-the-progressevent-interface // https://xhr.spec.whatwg.org/#firing-events-using-the-progressevent-interface
.lengthComputable = opts.total > 0, .lengthComputable = opts.total > 0,
@@ -447,6 +450,7 @@ pub const XMLHttpRequest = struct {
const reader = self.req.?.reader(); const reader = self.req.?.reader();
var buffer: [1024]u8 = undefined; var buffer: [1024]u8 = undefined;
var ln = buffer.len; var ln = buffer.len;
var prev_dispatch: ?std.time.Instant = null;
while (ln > 0) { while (ln > 0) {
ln = reader.read(&buffer) catch |e| { ln = reader.read(&buffer) catch |e| {
buf.deinit(self.alloc); buf.deinit(self.alloc);
@@ -458,7 +462,13 @@ pub const XMLHttpRequest = struct {
}; };
loaded = loaded + ln; loaded = loaded + ln;
// TODO dispatch only if 50ms have passed. // Dispatch only if 50ms have passed.
const now = std.time.Instant.now() catch |e| {
buf.deinit(self.alloc);
return self.onErr(e);
};
if (prev_dispatch != null and now.since(prev_dispatch.?) < min_delay) continue;
defer prev_dispatch = now;
self.state = LOADING; self.state = LOADING;
self.dispatchEvt("readystatechange"); self.dispatchEvt("readystatechange");