public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix executor used in resolveNode

Browse Source
This commit is contained in:
sjorsdonkers
2025-04-22 11:11:46 +02:00
committed by Sjors
parent 8897d9179c
commit 09850d7500
5 changed files with 49 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/runtime/js.zig
View File

@@ -364,7 +364,7 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
executor.call_arena = executor._call_arena_instance.allocator();
executor.scope_arena = executor._scope_arena_instance.allocator();
errdefer self.stopExecutor(executor);
errdefer self.stopExecutor(executor, false); // Note: This likely has issues as context.exit() is errdefered as well
// Custom exception
// NOTE: there is no way in v8 to subclass the Error built-in type
@@ -385,8 +385,8 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
// a Context, it's managed by the garbage collector. So, when the
// `gc_hints` option is enabled, we'll use the `lowMemoryNotification`
// call on the isolate to encourage v8 to free the context.
pub fn stopExecutor(self: *Self, executor: *Executor) void {
executor.deinit();
pub fn stopExecutor(self: *Self, executor: *Executor, exit_context: bool) void {
executor.deinit(exit_context);
self.executor_pool.destroy(executor);
if (self.gc_hints) {
self.isolate.lowMemoryNotification();
@@ -818,11 +818,10 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
// no init, must be initialized via env.startExecutor()
// not public, must be destroyed via env.stopExecutor()
fn deinit(self: *Executor) void {
if (self.scope != null) {
self.endScope();
}
self.context.exit();
fn deinit(self: *Executor, exit_context: bool) void {
if (self.scope != null) self.endScope();
if (exit_context) self.context.exit();
self.handle_scope.deinit();
self._call_arena_instance.deinit();