public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #732 from lightpanda-io/intersection_observer_threshold

Browse Source 
IntersectionObserver's threshold option should be an union
This commit is contained in:
Karl Seguin
2025-05-30 21:28:18 +08:00
committed by GitHub
parent 7202d758a2 9a2c0067f1
commit 0acbb20c00
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/browser/dom/intersection_observer.zig
View File

@@ -51,7 +51,7 @@ pub const IntersectionObserver = struct {
var options = IntersectionObserverOptions{ var options = IntersectionObserverOptions{
.root = parser.documentToNode(parser.documentHTMLToDocument(page.window.document)), .root = parser.documentToNode(parser.documentHTMLToDocument(page.window.document)),
.rootMargin = "0px 0px 0px 0px", .rootMargin = "0px 0px 0px 0px",
.threshold = &.{0.0}, .threshold = .{ .single = 0.0 },
}; };
if (options_) |*o| { if (options_) |*o| {
if (o.root) |root| { if (o.root) |root| {
@@ -107,7 +107,12 @@ pub const IntersectionObserver = struct {
const IntersectionObserverOptions = struct { const IntersectionObserverOptions = struct {
root: ?*parser.Node, // Element or Document root: ?*parser.Node, // Element or Document
rootMargin: ?[]const u8, rootMargin: ?[]const u8,
threshold: ?[]const f32, threshold: ?Threshold,
const Threshold = union(enum) {
single: f32,
list: []const f32,
};
}; };
// https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserverEntry // https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserverEntry