Merge pull request #1312 from lightpanda-io/stagehand-zigdom

Stagehand zigdom

src/cdp/cdp.zig

@@ -152,7 +152,7 @@ pub fn CDPT(comptime TypeProvider: type) type {
             }
 
             if (is_startup) {
-                dispatchStartupCommand(&command) catch |err| {
+                dispatchStartupCommand(&command, input.method) catch |err| {
                     command.sendError(-31999, @errorName(err), .{}) catch {};
                     return err;
                 };
@@ -174,7 +174,23 @@ pub fn CDPT(comptime TypeProvider: type) type {
         // "special" handling - the bare minimum we need to do until the driver
         // switches to a real BrowserContext.
         // (I can imagine this logic will become driver-specific)
-        fn dispatchStartupCommand(command: anytype) !void {
+        fn dispatchStartupCommand(command: anytype, method: []const u8) !void {
+            // Stagehand parses the response and error if we don't return a
+            // correct one for this call.
+            if (std.mem.eql(u8, method, "Page.getFrameTree")) {
+                return command.sendResult(.{
+                    .frameTree = .{
+                        .frame = .{
+                            .id = "TID-STARTUP-B",
+                            .loaderId = LOADER_ID,
+                            .securityOrigin = URL_BASE,
+                            .url = "about:blank",
+                            .secureContextType = "Secure",
+                        },
+                    },
+                }, .{});
+            }
+
             return command.sendResult(null, .{});
         }
 

src/cdp/domains/target.zig

@@ -36,6 +36,7 @@ pub fn processMessage(cmd: anytype) !void {
         sendMessageToTarget,
         setAutoAttach,
         setDiscoverTargets,
+        activateTarget,
     }, cmd.input.action) orelse return error.UnknownMethod;
 
     switch (action) {
@@ -51,14 +52,16 @@ pub fn processMessage(cmd: anytype) !void {
         .sendMessageToTarget => return sendMessageToTarget(cmd),
         .setAutoAttach => return setAutoAttach(cmd),
         .setDiscoverTargets => return setDiscoverTargets(cmd),
+        .activateTarget => return cmd.sendResult(null, .{}),
     }
 }
 
 fn getTargets(cmd: anytype) !void {
-    // Some clients like Stagehand expects to have an existing context.
+    // If no context available, return an empty array.
-    const bc = cmd.browser_context orelse cmd.createBrowserContext() catch |err| switch (err) {
+    const bc = cmd.browser_context orelse {
-        error.AlreadyExists => unreachable,
+        return cmd.sendResult(.{
-        else => return err,
+            .targetInfos = [_]TargetInfo{},
+        }, .{ .include_session_id = false });
     };
 
     const target_id = bc.target_id orelse {
@@ -230,10 +233,6 @@ fn attachToTarget(cmd: anytype) !void {
         return error.UnknownTargetId;
     }
 
-    if (bc.session_id != null) {
-        return error.SessionAlreadyLoaded;
-    }
-
     if (bc.session_id == null) {
         try doAttachtoTarget(cmd, target_id);
     }