mirror of
https://github.com/lightpanda-io/browser.git
synced 2026-03-31 09:29:42 +00:00
Rename page.id to page._frame_id
This field was recently added and is used to generate correct frameIds in CDP messages. They remain the same during a navigation event, so calling them page.id might cause surprises since navigation events create new pages, but retain the original id. Hence, frame_id is more accurate and hopefully less surprising. (This is a small cleanup prior to doing some iframe navigation work).
This commit is contained in:
@@ -72,9 +72,9 @@ pub fn init(input: Input, options: ?InitOpts, page: *Page) !js.Promise {
|
||||
|
||||
try http_client.request(.{
|
||||
.ctx = fetch,
|
||||
.page_id = page.id,
|
||||
.url = request._url,
|
||||
.method = request._method,
|
||||
.frame_id = page._frame_id,
|
||||
.body = request._body,
|
||||
.headers = headers,
|
||||
.resource_type = .fetch,
|
||||
|
||||
Reference in New Issue
Block a user