public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1514 from lightpanda-io/selection_wpt_fixes

Browse Source 
Fixes extend-20.html and extend-00.html
This commit is contained in:
Karl Seguin
2026-02-11 07:14:14 +08:00
committed by GitHub
parent 32ca170c4d 1efd13545e
commit 11d8412591
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/browser/webapi/Selection.zig
View File

@@ -202,6 +202,13 @@ pub fn extend(self: *Selection, node: *Node, _offset: ?u32, page: *Page) !void {
const range = self._range orelse return error.InvalidState; const range = self._range orelse return error.InvalidState;
const offset = _offset orelse 0; const offset = _offset orelse 0;
// If the node is not contained in the document, do not change the selection
if (!page.document.asNode().contains(node)) {
return;
}
if (node._type == .document_type) return error.InvalidNodeType;
if (offset > node.getLength()) { if (offset > node.getLength()) {
return error.IndexSizeError; return error.IndexSizeError;
} }
@@ -306,12 +313,17 @@ pub fn modify(
} }
pub fn selectAllChildren(self: *Selection, parent: *Node, page: *Page) !void { pub fn selectAllChildren(self: *Selection, parent: *Node, page: *Page) !void {
if (parent._type == .document_type) return error.InvalidNodeTypeError; if (parent._type == .document_type) return error.InvalidNodeType;
// If the node is not contained in the document, do not change the selection
if (!page.document.asNode().contains(parent)) {
return;
}
const range = try Range.init(page); const range = try Range.init(page);
try range.setStart(parent, 0); try range.setStart(parent, 0);
const child_count = parent.getLength(); const child_count = parent.getChildrenCount();
try range.setEnd(parent, @intCast(child_count)); try range.setEnd(parent, @intCast(child_count));
self._range = range; self._range = range;
@@ -426,7 +438,7 @@ pub const JsApi = struct {
pub const modify = bridge.function(Selection.modify, .{}); pub const modify = bridge.function(Selection.modify, .{});
pub const removeAllRanges = bridge.function(Selection.removeAllRanges, .{}); pub const removeAllRanges = bridge.function(Selection.removeAllRanges, .{});
pub const removeRange = bridge.function(Selection.removeRange, .{ .dom_exception = true }); pub const removeRange = bridge.function(Selection.removeRange, .{ .dom_exception = true });
pub const selectAllChildren = bridge.function(Selection.selectAllChildren, .{}); pub const selectAllChildren = bridge.function(Selection.selectAllChildren, .{ .dom_exception = true });
pub const setBaseAndExtent = bridge.function(Selection.setBaseAndExtent, .{ .dom_exception = true }); pub const setBaseAndExtent = bridge.function(Selection.setBaseAndExtent, .{ .dom_exception = true });
pub const setPosition = bridge.function(Selection.collapse, .{ .dom_exception = true }); pub const setPosition = bridge.function(Selection.collapse, .{ .dom_exception = true });
pub const toString = bridge.function(Selection.toString, .{}); pub const toString = bridge.function(Selection.toString, .{});