diff --git a/src/browser/js/Inspector.zig b/src/browser/js/Inspector.zig index a9032e33..aa35be7b 100644 --- a/src/browser/js/Inspector.zig +++ b/src/browser/js/Inspector.zig @@ -130,6 +130,12 @@ pub fn contextCreated( pub fn contextDestroyed(self: *Inspector, context: *const v8.Context) void { v8.v8_inspector__Inspector__ContextDestroyed(self.handle, context); + + if (self.default_context) |*dc| { + if (v8.v8__Global__IsEqual(dc, context)) { + self.default_context = null; + } + } } pub fn resetContextGroup(self: *const Inspector) void { diff --git a/src/cdp/cdp.zig b/src/cdp/cdp.zig index 8783e5a0..6d14c627 100644 --- a/src/cdp/cdp.zig +++ b/src/cdp/cdp.zig @@ -459,6 +459,12 @@ pub fn BrowserContext(comptime CDP_T: type) type { } self.isolated_worlds.clearRetainingCapacity(); + // do this before closeSession, since we don't want to process any + // new notification (Or maybe, instead of the deinit above, we just + // rely on those notifications to do our normal cleanup?) + + self.notification.unregisterAll(self); + // If the session has a page, we need to clear it first. The page // context is always nested inside of the isolated world context, // so we need to shutdown the page one first. @@ -466,7 +472,6 @@ pub fn BrowserContext(comptime CDP_T: type) type { self.node_registry.deinit(); self.node_search_list.deinit(); - self.notification.unregisterAll(self); self.notification.deinit(); if (self.http_proxy_changed) { diff --git a/src/cdp/domains/page.zig b/src/cdp/domains/page.zig index d4b7b301..c8b39d65 100644 --- a/src/cdp/domains/page.zig +++ b/src/cdp/domains/page.zig @@ -290,6 +290,10 @@ pub fn pageNavigate(bc: anytype, event: *const Notification.PageNavigate) !void } pub fn pageRemove(bc: anytype) !void { + // Clear all remote object mappings to prevent stale objectIds from being used + // after the context is destroy + bc.inspector_session.inspector.resetContextGroup(); + // The main page is going to be removed, we need to remove contexts from other worlds first. for (bc.isolated_worlds.items) |isolated_world| { try isolated_world.removeContext();