public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix response of runtime.Evaluate

Browse Source 
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
This commit is contained in:
Francis Bouvier
2024-07-09 16:10:25 +02:00
parent 41409031fd
commit 14a3a662fd
1 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/cdp/runtime.zig
View File

@@ -147,17 +147,32 @@ fn evaluate(
const session = ctx.browser.currentSession(); const session = ctx.browser.currentSession();
// TODO: should we use instead the allocator of the page? // TODO: should we use instead the allocator of the page?
// the following code does not work with session.page.?.arena.allocator() as alloc // the following code does not work with session.page.?.arena.allocator() as alloc
const res = try runtimeEvaluate(session.alloc, id, session.env, params.expression, "cdp");
_ = try runtimeEvaluate(session.alloc, id, session.env, params.expression, "cdp"); // check result
const res_type = try res.typeOf(session.env);
// TODO: Resp should depends on JS result returned by the JS engine // TODO: Resp should depends on JS result returned by the JS engine
const Resp = struct { const Resp = struct {
type: []const u8 = "object", result: struct {
className: []const u8 = "UtilityScript", type: []const u8,
description: []const u8 = "UtilityScript", subtype: ?[]const u8 = null,
objectId: []const u8 = "7481631759780215274.3.2", className: ?[]const u8 = null,
description: ?[]const u8 = null,
objectId: ?[]const u8 = null,
},
}; };
return result(alloc, id, Resp, Resp{}, msg.sessionID); var resp = Resp{
.result = .{
.type = @tagName(res_type),
},
};
if (res_type == .object) {
resp.result.className = "Object";
resp.result.description = "Object";
resp.result.objectId = "-9051357107442861868.3.2";
}
return result(alloc, id, Resp, resp, msg.sessionID);
} }
fn addBinding( fn addBinding(