public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1705 from lightpanda-io/nikneym/track

Browse Source 
` Track`: implement kind and constants
This commit is contained in:
Karl Seguin
2026-03-04 07:34:12 +08:00
committed by GitHub
parent 6f0cd87d1c febe321aef
commit 1c07d786a0
3 changed files with 146 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/browser/Page.zig
View File

@@ -1876,7 +1876,7 @@ pub fn createElementNS(self: *Page, namespace: Element.Namespace, name: []const
Element.Html.Track,
namespace,
attribute_iterator,
.{ ._proto = undefined },
.{ ._proto = undefined, ._kind = comptime .wrap("subtitles"), ._ready_state = .none },
),
else => {},
},

75
src/browser/tests/element/html/track.html Normal file
View File

@@ -0,0 +1,75 @@
<!DOCTYPE html>
<script src="../../testing.js"></script>
<video id="video1">
<track id="track1" kind="subtitles">
<track id="track2" kind="captions">
<track id="track3" kind="invalid-kind">
</video>
<script id="instanceof">
{
const track = document.createElement("track");
testing.expectEqual(true, track instanceof HTMLTrackElement);
testing.expectEqual("[object HTMLTrackElement]", track.toString());
}
</script>
<script id="kind_default">
{
const track = document.createElement("track");
testing.expectEqual("subtitles", track.kind);
}
</script>
<script id="kind_valid_values">
{
const track = document.createElement("track");
track.kind = "captions";
testing.expectEqual("captions", track.kind);
track.kind = "descriptions";
testing.expectEqual("descriptions", track.kind);
track.kind = "chapters";
testing.expectEqual("chapters", track.kind);
track.kind = "metadata";
testing.expectEqual("metadata", track.kind);
}
</script>
<script id="kind_invalid">
{
const track = document.createElement("track");
track.kind = null;
testing.expectEqual("metadata", track.kind);
track.kind = "Subtitles";
testing.expectEqual("subtitles", track.kind);
track.kind = "";
testing.expectEqual("metadata", track.kind);
}
</script>
<script id="constants">
{
const track = document.createElement("track");
testing.expectEqual(0, track.NONE);
testing.expectEqual(1, track.LOADING);
testing.expectEqual(2, track.LOADED);
testing.expectEqual(3, track.ERROR);
}
</script>
<script id="constants_static">
{
testing.expectEqual(0, HTMLTrackElement.NONE);
testing.expectEqual(1, HTMLTrackElement.LOADING);
testing.expectEqual(2, HTMLTrackElement.LOADED);
testing.expectEqual(3, HTMLTrackElement.ERROR);
}
</script>

70
src/browser/webapi/element/html/Track.zig
View File

@@ -1,4 +1,26 @@
// Copyright (C) 2023-2026 Lightpanda (Selecy SAS)
//
// Francis Bouvier <francis@lightpanda.io>
// Pierre Tachoire <pierre@lightpanda.io>
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
const std = @import("std");
const js = @import("../../../js/js.zig");
const String = @import("../../../../string.zig").String;
const Node = @import("../../Node.zig");
const Element = @import("../../Element.zig");
const HtmlElement = @import("../Html.zig");
@@ -6,6 +28,10 @@ const HtmlElement = @import("../Html.zig");
const Track = @This();
_proto: *HtmlElement,
_kind: String,
_ready_state: ReadyState,
const ReadyState = enum(u8) { none, loading, loaded, @"error" };
pub fn asElement(self: *Track) *Element {
return self._proto._proto;
@@ -14,6 +40,38 @@ pub fn asNode(self: *Track) *Node {
return self.asElement().asNode();
}
pub fn setKind(self: *Track, maybe_kind: ?String) void {
const kind = maybe_kind orelse {
self._kind = comptime .wrap("metadata");
return;
};
// Special case, for some reason, FF does this case-insensitive.
if (std.ascii.eqlIgnoreCase(kind.str(), "subtitles")) {
self._kind = comptime .wrap("subtitles");
return;
}
if (kind.eql(comptime .wrap("captions"))) {
self._kind = comptime .wrap("captions");
return;
}
if (kind.eql(comptime .wrap("descriptions"))) {
self._kind = comptime .wrap("descriptions");
return;
}
if (kind.eql(comptime .wrap("chapters"))) {
self._kind = comptime .wrap("chapters");
return;
}
// Anything else must be considered as `metadata`.
self._kind = comptime .wrap("metadata");
}
pub fn getKind(self: *const Track) String {
return self._kind;
}
pub const JsApi = struct {
pub const bridge = js.Bridge(Track);
@@ -22,4 +80,16 @@ pub const JsApi = struct {
pub const prototype_chain = bridge.prototypeChain();
pub var class_id: bridge.ClassId = undefined;
};
pub const kind = bridge.accessor(Track.getKind, Track.setKind, .{});
pub const NONE = bridge.property(@as(u16, @intFromEnum(ReadyState.none)), .{ .template = true });
pub const LOADING = bridge.property(@as(u16, @intFromEnum(ReadyState.loading)), .{ .template = true });
pub const LOADED = bridge.property(@as(u16, @intFromEnum(ReadyState.loaded)), .{ .template = true });
pub const ERROR = bridge.property(@as(u16, @intFromEnum(ReadyState.@"error")), .{ .template = true });
};
const testing = @import("../../../../testing.zig");
test "WebApi: HTML.Track" {
try testing.htmlRunner("element/html/track.html", .{});
}