From 1ec3e156fbe00248e6a611bd9f906e215f4df411 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Mon, 16 Mar 2026 07:28:14 +0800 Subject: [PATCH] Fix partitionKey ignore PR Fixes https://github.com/lightpanda-io/browser/pull/1821 so that it compiles --- src/cdp/domains/network.zig | 2 +- src/cdp/domains/storage.zig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cdp/domains/network.zig b/src/cdp/domains/network.zig index 5c422a8d..3599a88d 100644 --- a/src/cdp/domains/network.zig +++ b/src/cdp/domains/network.zig @@ -122,7 +122,7 @@ fn deleteCookies(cmd: anytype) !void { // This allows Puppeteer's page.setCookie() to work, which sends deleteCookies // with partitionKey as part of its cookie-setting workflow. if (params.partitionKey != null) { - log.debug(.network, "partitionKey ignored in deleteCookies", .{}); + log.warn(.not_implemented, "partition key", .{.src = "deleteCookies"}); } const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; diff --git a/src/cdp/domains/storage.zig b/src/cdp/domains/storage.zig index 497f7efa..92a8018a 100644 --- a/src/cdp/domains/storage.zig +++ b/src/cdp/domains/storage.zig @@ -132,7 +132,7 @@ pub fn setCdpCookie(cookie_jar: *CookieJar, param: CdpCookie) !void { // This allows Puppeteer's page.setCookie() to work, which may send cookies with // partitionKey as part of its cookie-setting workflow. if (param.partitionKey != null) { - log.debug(.storage, "partitionKey ignored in setCdpCookie", .{}); + log.warn(.not_implemented, "partition key", .{.src = "setCdpCookie"}); } // Still reject unsupported features if (param.priority != .Medium or param.sameParty != null or param.sourceScheme != null) {