diff --git a/src/browser/actions.zig b/src/browser/actions.zig index 641466b8..ceb698e2 100644 --- a/src/browser/actions.zig +++ b/src/browser/actions.zig @@ -23,8 +23,8 @@ const Element = @import("webapi/Element.zig"); const Event = @import("webapi/Event.zig"); const Page = @import("Page.zig"); -pub fn clickNode(dom_node: *DOMNode, page: *Page) !void { - if (dom_node.is(Element)) |el| { +pub fn click(node: *DOMNode, page: *Page) !void { + if (node.is(Element)) |el| { if (el.is(Element.Html)) |html_el| { html_el.click(page) catch |err| { lp.log.err(.app, "click failed", .{ .err = err }); @@ -38,8 +38,8 @@ pub fn clickNode(dom_node: *DOMNode, page: *Page) !void { } } -pub fn fillNode(dom_node: *DOMNode, text: []const u8, page: *Page) !void { - if (dom_node.is(Element)) |el| { +pub fn fill(node: *DOMNode, text: []const u8, page: *Page) !void { + if (node.is(Element)) |el| { if (el.is(Element.Html.Input)) |input| { input.setValue(text, page) catch |err| { lp.log.err(.app, "fill input failed", .{ .err = err }); @@ -69,8 +69,8 @@ pub fn fillNode(dom_node: *DOMNode, text: []const u8, page: *Page) !void { } } -pub fn scrollNode(dom_node: ?*DOMNode, x: i32, y: i32, page: *Page) !void { - if (dom_node) |n| { +pub fn scroll(node: ?*DOMNode, x: i32, y: i32, page: *Page) !void { + if (node) |n| { if (n.is(Element)) |el| { if (x != 0) { el.setScrollLeft(x, page) catch {}; diff --git a/src/cdp/domains/lp.zig b/src/cdp/domains/lp.zig index 4443629e..ed6c6994 100644 --- a/src/cdp/domains/lp.zig +++ b/src/cdp/domains/lp.zig @@ -165,7 +165,7 @@ fn clickNode(cmd: anytype) !void { const input_node_id = params.nodeId orelse params.backendNodeId orelse return error.InvalidParam; const node = bc.node_registry.lookup_by_id.get(input_node_id) orelse return error.InvalidNodeId; - lp.actions.clickNode(node.dom, page) catch |err| { + lp.actions.click(node.dom, page) catch |err| { if (err == error.InvalidNodeType) return error.InvalidParam; return error.InternalError; }; @@ -187,7 +187,7 @@ fn fillNode(cmd: anytype) !void { const input_node_id = params.nodeId orelse params.backendNodeId orelse return error.InvalidParam; const node = bc.node_registry.lookup_by_id.get(input_node_id) orelse return error.InvalidNodeId; - lp.actions.fillNode(node.dom, params.text, page) catch |err| { + lp.actions.fill(node.dom, params.text, page) catch |err| { if (err == error.InvalidNodeType) return error.InvalidParam; return error.InternalError; }; @@ -218,7 +218,7 @@ fn scrollNode(cmd: anytype) !void { target_node = node.dom; } - lp.actions.scrollNode(target_node, x, y, page) catch |err| { + lp.actions.scroll(target_node, x, y, page) catch |err| { if (err == error.InvalidNodeType) return error.InvalidParam; return error.InternalError; }; diff --git a/src/mcp/tools.zig b/src/mcp/tools.zig index 65bd3ee8..6f256dca 100644 --- a/src/mcp/tools.zig +++ b/src/mcp/tools.zig @@ -445,7 +445,7 @@ fn handleClick(server: *Server, arena: std.mem.Allocator, id: std.json.Value, ar return server.sendError(id, .InvalidParams, "Node not found"); }; - lp.actions.clickNode(node.dom, page) catch |err| { + lp.actions.click(node.dom, page) catch |err| { if (err == error.InvalidNodeType) { return server.sendError(id, .InvalidParams, "Node is not an HTML element"); } @@ -471,7 +471,7 @@ fn handleFill(server: *Server, arena: std.mem.Allocator, id: std.json.Value, arg return server.sendError(id, .InvalidParams, "Node not found"); }; - lp.actions.fillNode(node.dom, args.text, page) catch |err| { + lp.actions.fill(node.dom, args.text, page) catch |err| { if (err == error.InvalidNodeType) { return server.sendError(id, .InvalidParams, "Node is not an input, textarea or select"); } @@ -505,7 +505,7 @@ fn handleScroll(server: *Server, arena: std.mem.Allocator, id: std.json.Value, a target_node = node.dom; } - lp.actions.scrollNode(target_node, x, y, page) catch |err| { + lp.actions.scroll(target_node, x, y, page) catch |err| { if (err == error.InvalidNodeType) { return server.sendError(id, .InvalidParams, "Node is not an element"); }