From 226dafa9e36db8ccf5eae953738ce2c7bb06bc98 Mon Sep 17 00:00:00 2001 From: sjorsdonkers <72333389+sjorsdonkers@users.noreply.github.com> Date: Mon, 19 May 2025 16:27:55 +0200 Subject: [PATCH] refix rebase regressions --- src/browser/dom/element.zig | 4 ++-- src/browser/html/document.zig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/browser/dom/element.zig b/src/browser/dom/element.zig index 795da664..77d527ea 100644 --- a/src/browser/dom/element.zig +++ b/src/browser/dom/element.zig @@ -370,7 +370,7 @@ pub const Element = struct { pub fn _getBoundingClientRect(self: *parser.Element, state: *SessionState) !DOMRect { // Since we are lazy rendering we need to do this check. We could store the renderer in a viewport such that it could cache these, but it would require tracking changes. const root = try parser.nodeGetRootNode(parser.elementToNode(self)); - if (root != parser.documentToNode(parser.documentHTMLToDocument(state.document.?))) { + if (root != parser.documentToNode(parser.documentHTMLToDocument(state.window.document.?))) { return DOMRect{ .x = 0, .y = 0, .width = 0, .height = 0 }; } return state.renderer.getRect(self); @@ -381,7 +381,7 @@ pub const Element = struct { // Returns an empty array if the element is eventually detached from the main window pub fn _getClientRects(self: *parser.Element, state: *SessionState) ![]DOMRect { const root = try parser.nodeGetRootNode(parser.elementToNode(self)); - if (root != parser.documentToNode(parser.documentHTMLToDocument(state.document.?))) { + if (root != parser.documentToNode(parser.documentHTMLToDocument(state.window.document.?))) { return &.{}; } const heap_ptr = try state.call_arena.create(DOMRect); diff --git a/src/browser/html/document.zig b/src/browser/html/document.zig index a2610c94..c5f6f572 100644 --- a/src/browser/html/document.zig +++ b/src/browser/html/document.zig @@ -255,10 +255,10 @@ pub const HTMLDocument = struct { // Thus we can add the HtmlHtmlElement and it's child HTMLBodyElement to the returned list. // TBD Should we instead return every parent that is an element? Note that a child does not physically need to be overlapping the parent. // Should we do a render pass on demand? - const doc_elem = try parser.documentGetDocumentElement(parser.documentHTMLToDocument(state.document.?)) orelse { + const doc_elem = try parser.documentGetDocumentElement(parser.documentHTMLToDocument(state.window.document.?)) orelse { return list.items; }; - if (try parser.documentHTMLBody(state.document.?)) |body| { + if (try parser.documentHTMLBody(state.window.document.?)) |body| { list.appendAssumeCapacity(try Element.toInterface(parser.bodyToElement(body))); } list.appendAssumeCapacity(try Element.toInterface(doc_elem));