From 24491f0dfeeff991259c8b1b43cae975c87a115f Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Fri, 27 Feb 2026 14:34:20 +0800 Subject: [PATCH] fix String copy/reference --- src/browser/webapi/Node.zig | 4 ++-- src/browser/webapi/Range.zig | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/browser/webapi/Node.zig b/src/browser/webapi/Node.zig index a62b0b95..4b351b6f 100644 --- a/src/browser/webapi/Node.zig +++ b/src/browser/webapi/Node.zig @@ -270,7 +270,7 @@ pub fn getTextContent(self: *Node, writer: *std.Io.Writer) error{WriteFailed}!vo try child.getTextContent(writer); } }, - .cdata => |c| try writer.writeAll(c.getData().str()), + .cdata => |c| try writer.writeAll(c._data.str()), .document => {}, .document_type => {}, .attribute => |attr| try writer.writeAll(attr._value.str()), @@ -1028,7 +1028,7 @@ pub const JsApi = struct { try self.getTextContent(&buf.writer); return buf.written(); }, - .cdata => |cdata| return cdata.getData().str(), + .cdata => |cdata| return cdata._data.str(), .attribute => |attr| return attr._value.str(), .document => return null, .document_type => return null, diff --git a/src/browser/webapi/Range.zig b/src/browser/webapi/Range.zig index d7e7d8c5..840fa227 100644 --- a/src/browser/webapi/Range.zig +++ b/src/browser/webapi/Range.zig @@ -388,8 +388,8 @@ pub fn deleteContents(self: *Range, page: *Page) !void { // Complex case: different containers // Handle start container - if it's a text node, truncate it - if (self._proto._start_container.is(Node.CData)) |_| { - const text_data = self._proto._start_container.getData().str(); + if (self._proto._start_container.is(Node.CData)) |cdata| { + const text_data = cdata._data.str(); if (self._proto._start_offset < text_data.len) { // Keep only the part before start_offset const new_text = text_data[0..self._proto._start_offset]; @@ -398,8 +398,8 @@ pub fn deleteContents(self: *Range, page: *Page) !void { } // Handle end container - if it's a text node, truncate it - if (self._proto._end_container.is(Node.CData)) |_| { - const text_data = self._proto._end_container.getData().str(); + if (self._proto._end_container.is(Node.CData)) |cdata| { + const text_data = cdata._data.str(); if (self._proto._end_offset < text_data.len) { // Keep only the part from end_offset onwards const new_text = text_data[self._proto._end_offset..];