public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 06:23:45 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

"load" event must be dispatched even if onload not set

Browse Source 
Resolves the bug that cause event listeners added through `EventTarget` not executing if `onload` not set.
This commit is contained in:
Halil Durak
2026-01-23 11:53:00 +03:00
parent b6a0f40760
commit 24d94e42a1
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/webapi/element/html/Image.zig
View File

@@ -162,17 +162,21 @@ pub const Build = struct {
const image = self.asElement(); const image = self.asElement();
// Exit if src not set. We might want to check if src point to valid image. // Exit if src not set. We might want to check if src point to valid image.
_ = image.getAttributeSafe("src") orelse return; _ = image.getAttributeSafe("src") orelse return;
// Exit if there's no `onload`.
const on_load_str = image.getAttributeSafe("onload") orelse return;
// Set `onload` if provided.
blk: {
// Exit if there's no `onload`.
const on_load_str = image.getAttributeSafe("onload") orelse break :blk;
// Derive function from string. // Derive function from string.
const on_load_func = page.js.stringToPersistedFunction(on_load_str) catch |err| { const on_load_func = page.js.stringToPersistedFunction(on_load_str) catch |err| {
log.err(.js, "Image.onload", .{ .err = err, .str = on_load_str }); log.err(.js, "Image.onload", .{ .err = err, .str = on_load_str });
return; break :blk;
}; };
// Set onload. // Set onload.
self._on_load = on_load_func; self._on_load = on_load_func;
}
// Since src set, we should send dispatch operation to Scheduler.
const args = try page._factory.create(CallbackParams{ const args = try page._factory.create(CallbackParams{
.page = page, .page = page,
.element = image, .element = image,
@@ -200,7 +204,7 @@ pub const Build = struct {
const event_target = _element.asEventTarget(); const event_target = _element.asEventTarget();
const event = try Event.initTrusted("load", .{}, _page); const event = try Event.initTrusted("load", .{}, _page);
// If onload still there, dispatch with it. // If onload provided, dispatch with it.
if (_img._on_load) |_on_load| { if (_img._on_load) |_on_load| {
var ls: js.Local.Scope = undefined; var ls: js.Local.Scope = undefined;
_page.js.localScope(&ls); _page.js.localScope(&ls);