public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-28 22:53:28 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

remove duplicate put, add more assertions

Browse Source
This commit is contained in:
Karl Seguin
2025-09-24 22:44:46 +08:00
parent b692c5db60
commit 252fd78473
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/runtime/js.zig
View File

@@ -850,6 +850,7 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
const arena = self.context_arena; const arena = self.context_arena;
const owned_url = try arena.dupe(u8, url); const owned_url = try arena.dupe(u8, url);
try self.module_identifier.putNoClobber(arena, m.getIdentityHash(), owned_url); try self.module_identifier.putNoClobber(arena, m.getIdentityHash(), owned_url);
errdefer _ = self.module_identifier.remove(m.getIdentityHash()); errdefer _ = self.module_identifier.remove(m.getIdentityHash());
@@ -900,7 +901,6 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
.resolver_promise = null, .resolver_promise = null,
}; };
} }
try self.module_identifier.put(arena, m.getIdentityHash(), owned_url);
return if (comptime want_result) gop.value_ptr.* else {}; return if (comptime want_result) gop.value_ptr.* else {};
} }
@@ -1763,6 +1763,8 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
// We need to do part of what the first case is going to do in // We need to do part of what the first case is going to do in
// `dynamicModuleSourceCallback`, but we can skip some steps // `dynamicModuleSourceCallback`, but we can skip some steps
// since the module is alrady loaded, // since the module is alrady loaded,
std.debug.assert(gop.value_ptr.module != null);
std.debug.assert(gop.value_ptr.module_promise != null);
// like before, we want to set this up so that if anything else // like before, we want to set this up so that if anything else
// tries to load this module, it can just return our promise // tries to load this module, it can just return our promise
@@ -1818,6 +1820,7 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
std.debug.assert(module_entry.module != null); std.debug.assert(module_entry.module != null);
std.debug.assert(module_entry.module_promise != null); std.debug.assert(module_entry.module_promise != null);
std.debug.assert(module_entry.resolver_promise != null); std.debug.assert(module_entry.resolver_promise != null);
std.debug.assert(self.module_cache.contains(state.specifier));
// We've gotten the source for the module and are evaluating it. // We've gotten the source for the module and are evaluating it.
// You might thing we're done, but the module evaluation is // You might thing we're done, but the module evaluation is