public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-12-19 10:28:10 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Properly resolve inspector ObjectId back to a DOM Node

Browse Source 
Tweak element boundingRect and "renderer" based on what puppeteer needs.
This commit is contained in:
Karl Seguin
2025-12-10 15:28:24 +08:00
parent a7e0110acb
commit 27e58181fb
5 changed files with 101 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/cdp/domains/dom.zig
View File

@@ -429,12 +429,13 @@ fn getBoxModel(cmd: anytype) !void {
const rect = try element.getBoundingClientRect(page);
const quad = rectToQuad(rect);
const zero = [_]f64{0.0} ** 8;
return cmd.sendResult(.{ .model = BoxModel{
.content = quad,
.padding = quad,
.border = quad,
.margin = quad,
.padding = zero,
.border = zero,
.margin = zero,
.width = @intFromFloat(rect._width),
.height = @intFromFloat(rect._height),
} }, .{});
@@ -649,11 +650,11 @@ test "cdp.dom: getBoxModel" {
.params = .{ .nodeId = 6 },
});
try ctx.expectSentResult(.{ .model = BoxModel{
.content = Quad{ 0.0, 0.0, 1.0, 0.0, 1.0, 1.0, 0.0, 1.0 },
.padding = Quad{ 0.0, 0.0, 1.0, 0.0, 1.0, 1.0, 0.0, 1.0 },
.border = Quad{ 0.0, 0.0, 1.0, 0.0, 1.0, 1.0, 0.0, 1.0 },
.margin = Quad{ 0.0, 0.0, 1.0, 0.0, 1.0, 1.0, 0.0, 1.0 },
.width = 1,
.height = 1,
.content = Quad{ 0.0, 0.0, 5.0, 0.0, 5.0, 5.0, 0.0, 5.0 },
.padding = Quad{ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 },
.border = Quad{ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 },
.margin = Quad{ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 },
.width = 5,
.height = 5,
} }, .{ .id = 5 });
}