public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #606 from lightpanda-io/no_owned_slice

Browse Source 
remove unecessary toOwnedSlice
This commit is contained in:
Pierre Tachoire
2025-05-07 08:47:37 +02:00
committed by GitHub
parent 540dea9fc3 e44388b506
commit 28e4065890
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/dom/element.zig
View File

@@ -103,22 +103,14 @@ pub const Element = struct {
pub fn get_innerHTML(self: *parser.Element, state: *SessionState) ![]const u8 { pub fn get_innerHTML(self: *parser.Element, state: *SessionState) ![]const u8 {
var buf = std.ArrayList(u8).init(state.arena); var buf = std.ArrayList(u8).init(state.arena);
defer buf.deinit();
try dump.writeChildren(parser.elementToNode(self), buf.writer()); try dump.writeChildren(parser.elementToNode(self), buf.writer());
// TODO express the caller owned the slice. return buf.items;
// https://github.com/lightpanda-io/jsruntime-lib/issues/195
return buf.toOwnedSlice();
} }
pub fn get_outerHTML(self: *parser.Element, state: *SessionState) ![]const u8 { pub fn get_outerHTML(self: *parser.Element, state: *SessionState) ![]const u8 {
var buf = std.ArrayList(u8).init(state.arena); var buf = std.ArrayList(u8).init(state.arena);
defer buf.deinit();
try dump.writeNode(parser.elementToNode(self), buf.writer()); try dump.writeNode(parser.elementToNode(self), buf.writer());
// TODO express the caller owned the slice. return buf.items;
// https://github.com/lightpanda-io/jsruntime-lib/issues/195
return buf.toOwnedSlice();
} }
pub fn set_innerHTML(self: *parser.Element, str: []const u8) !void { pub fn set_innerHTML(self: *parser.Element, str: []const u8) !void {