From 2cdfc3f4c3f15c6499aed844325f460e3a15140a Mon Sep 17 00:00:00 2001
From: sjorsdonkers <72333389+sjorsdonkers@users.noreply.github.com>
Date: Wed, 21 May 2025 10:11:54 +0200
Subject: [PATCH] setChildNodes checks

---
 src/cdp/domains/dom.zig | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/cdp/domains/dom.zig b/src/cdp/domains/dom.zig
index 78d86ae2..d2e8cdb5 100644
--- a/src/cdp/domains/dom.zig
+++ b/src/cdp/domains/dom.zig
@@ -230,10 +230,9 @@ fn querySelectorAll(cmd: anytype) !void {
     const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse return error.UnknownNode;
 
     const arena = cmd.arena;
-    var selected_nodes = try css.querySelectorAll(arena, node._node, params.selector);
-    defer selected_nodes.deinit(arena);
-
+    const selected_nodes = try css.querySelectorAll(arena, node._node, params.selector);
     const nodes = selected_nodes.nodes.items;
+
     const node_ids = try arena.alloc(Node.Id, nodes.len);
     for (nodes, node_ids) |selected_node, *node_id| {
         node_id.* = (try bc.node_registry.register(selected_node)).id;
@@ -522,7 +521,7 @@ test "cdp.dom: querySelector Nodes found" {
         .method = "DOM.querySelector",
         .params = .{ .nodeId = 0, .selector = "p" },
     });
-    // TODO Check 1 or more "DOM.setChildNodes" was send
+    try ctx.expectSentEvent("DOM.setChildNodes", null, .{});
     try ctx.expectSentResult(.{ .nodeId = 5 }, .{ .id = 4 });
 
     try ctx.processMessage(.{
@@ -530,6 +529,6 @@ test "cdp.dom: querySelector Nodes found" {
         .method = "DOM.querySelectorAll",
         .params = .{ .nodeId = 0, .selector = "p" },
     });
-    // TODO Check 1 or more "DOM.setChildNodes" was send
+    try ctx.expectSentEvent("DOM.setChildNodes", null, .{});
     try ctx.expectSentResult(.{ .nodeIds = &.{5} }, .{ .id = 5 });
 }