From 3049bb0b9f8f33814aeece3365cd17c02158a2a5 Mon Sep 17 00:00:00 2001
From: Karl Seguin <k@openmymind.io>
Date: Thu, 10 Jul 2025 16:27:09 +0800
Subject: [PATCH] Fix async https requests over a http forward proxy

XHR requests to https (which is most XHR requests) currently don't work with
the implementation proxy because of this.
---
 src/http/client.zig | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/http/client.zig b/src/http/client.zig
index c3dbb41b..81c84394 100644
--- a/src/http/client.zig
+++ b/src/http/client.zig
@@ -240,6 +240,10 @@ pub const Client = struct {
         const proxy_type = self.proxy_type orelse return false;
         return proxy_type == .forward;
     }
+
+    fn isProxy(self: *const Client) bool {
+        return self.proxy_type != null;
+    }
 };
 
 const RequestOpts = struct {
@@ -792,8 +796,12 @@ pub const Request = struct {
             .conn = .{ .handler = async_handler, .protocol = .{ .plain = {} } },
         };
 
-        if (self._client.isConnectProxy() and self._proxy_secure) log.warn(.http, "ASYNC TLS CONNECT no impl.", .{});
-        if (self._request_secure) {
+        if (self._client.isConnectProxy() and self._proxy_secure) {
+            log.warn(.http, "not implemented", .{ .feature = "async tls connect" });
+        }
+
+        const is_proxy = self._client.isProxy();
+        if ((is_proxy and self._proxy_secure) or (!is_proxy and self._request_secure)) {
             if (self._connection_from_keepalive) {
                 // If the connection came from the keepalive pool, than we already
                 // have a TLS Connection.