public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1853 from lightpanda-io/fix-ignore-partition-key

Browse Source 
Fix ignore partition key
This commit is contained in:
Karl Seguin
2026-03-16 08:19:09 +08:00
committed by GitHub
parent dc7c6984fb 323ec0046c
commit 37462a16c5
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/cdp/domains/network.zig
View File

@@ -19,6 +19,7 @@
const std = @import("std"); const std = @import("std");
const lp = @import("lightpanda"); const lp = @import("lightpanda");
const Allocator = std.mem.Allocator; const Allocator = std.mem.Allocator;
const log = @import("../../log.zig");
const CdpStorage = @import("storage.zig"); const CdpStorage = @import("storage.zig");
@@ -117,7 +118,12 @@ fn deleteCookies(cmd: anytype) !void {
path: ?[]const u8 = null, path: ?[]const u8 = null,
partitionKey: ?CdpStorage.CookiePartitionKey = null, partitionKey: ?CdpStorage.CookiePartitionKey = null,
})) orelse return error.InvalidParams; })) orelse return error.InvalidParams;
if (params.partitionKey != null) return error.NotImplemented; // Silently ignore partitionKey since we don't support partitioned cookies (CHIPS).
// This allows Puppeteer's page.setCookie() to work, which sends deleteCookies
// with partitionKey as part of its cookie-setting workflow.
if (params.partitionKey != null) {
log.warn(.not_implemented, "partition key", .{ .src = "deleteCookies" });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
const cookies = &bc.session.cookie_jar.cookies; const cookies = &bc.session.cookie_jar.cookies;

9
src/cdp/domains/storage.zig
View File

@@ -128,7 +128,14 @@ pub const CdpCookie = struct {
}; };
pub fn setCdpCookie(cookie_jar: *CookieJar, param: CdpCookie) !void { pub fn setCdpCookie(cookie_jar: *CookieJar, param: CdpCookie) !void {
if (param.priority != .Medium or param.sameParty != null or param.sourceScheme != null or param.partitionKey != null) { // Silently ignore partitionKey since we don't support partitioned cookies (CHIPS).
// This allows Puppeteer's page.setCookie() to work, which may send cookies with
// partitionKey as part of its cookie-setting workflow.
if (param.partitionKey != null) {
log.warn(.not_implemented, "partition key", .{ .src = "setCdpCookie" });
}
// Still reject unsupported features
if (param.priority != .Medium or param.sameParty != null or param.sourceScheme != null) {
return error.NotImplemented; return error.NotImplemented;
} }