public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix context-leak

Browse Source
This commit is contained in:
Karl Seguin
2026-03-19 15:42:29 +08:00
parent d9c5f56500
commit 38e9f86088
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/browser/js/Env.zig
View File

@@ -300,10 +300,6 @@ pub fn createContext(self: *Env, page: *Page) !*Context {
v8.v8__Object__SetAlignedPointerInInternalField(global_obj, 0, tao); v8.v8__Object__SetAlignedPointerInInternalField(global_obj, 0, tao);
} }
// our window wrapped in a v8::Global
var global_global: v8.Global = undefined;
v8.v8__Global__New(isolate.handle, global_obj, &global_global);
const context_id = self.context_id; const context_id = self.context_id;
self.context_id = context_id + 1; self.context_id = context_id + 1;
@@ -333,6 +329,9 @@ pub fn createContext(self: *Env, page: *Page) !*Context {
// need to register the first one. // need to register the first one.
const gop = try session.identity_map.getOrPut(session.page_arena, @intFromPtr(page.window)); const gop = try session.identity_map.getOrPut(session.page_arena, @intFromPtr(page.window));
if (gop.found_existing == false) { if (gop.found_existing == false) {
// our window wrapped in a v8::Global
var global_global: v8.Global = undefined;
v8.v8__Global__New(isolate.handle, global_obj, &global_global);
gop.value_ptr.* = global_global; gop.value_ptr.* = global_global;
} }
} }