public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 12:44:43 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix file input value getter/setter per spec

Browse Source 
- getValue() returns "" for file inputs regardless of value attribute
- setValue("") is a no-op for file inputs (was throwing)
- setValue(non-empty) still throws InvalidStateError
- add _setValue bridge wrapper for [LegacyNullToEmptyString]: null → ""

Flips html/semantics/forms/the-input-element/valueMode.html (38/40 → 40/40).
This commit is contained in:
egrs
2026-02-21 14:43:45 +01:00
parent 5f459c0901
commit 39f9209374
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/webapi/element/html/Input.zig
View File

@@ -125,6 +125,7 @@ pub fn setType(self: *Input, typ: []const u8, page: *Page) !void {
} }
pub fn getValue(self: *const Input) []const u8 { pub fn getValue(self: *const Input) []const u8 {
if (self._input_type == .file) return "";
return self._value orelse self._default_value orelse switch (self._input_type) { return self._value orelse self._default_value orelse switch (self._input_type) {
.checkbox, .radio => "on", .checkbox, .radio => "on",
else => "", else => "",
@@ -132,8 +133,9 @@ pub fn getValue(self: *const Input) []const u8 {
} }
pub fn setValue(self: *Input, value: []const u8, page: *Page) !void { pub fn setValue(self: *Input, value: []const u8, page: *Page) !void {
// File inputs cannot have their value set programmatically for security reasons // File inputs: setting to empty string is a no-op, anything else throws
if (self._input_type == .file) { if (self._input_type == .file) {
if (value.len == 0) return;
return error.InvalidStateError; return error.InvalidStateError;
} }
// This should _not_ call setAttribute. It updates the current state only // This should _not_ call setAttribute. It updates the current state only
@@ -846,9 +848,17 @@ pub const JsApi = struct {
pub var class_id: bridge.ClassId = undefined; pub var class_id: bridge.ClassId = undefined;
}; };
/// Handles [LegacyNullToEmptyString]: null → "" per HTML spec.
fn setValueFromJS(self: *Input, js_value: js.Value, page: *Page) !void {
if (js_value.isNull()) {
return self.setValue("", page);
}
return self.setValue(try js_value.toZig([]const u8), page);
}
pub const onselectionchange = bridge.accessor(Input.getOnSelectionChange, Input.setOnSelectionChange, .{}); pub const onselectionchange = bridge.accessor(Input.getOnSelectionChange, Input.setOnSelectionChange, .{});
pub const @"type" = bridge.accessor(Input.getType, Input.setType, .{}); pub const @"type" = bridge.accessor(Input.getType, Input.setType, .{});
pub const value = bridge.accessor(Input.getValue, Input.setValue, .{ .dom_exception = true }); pub const value = bridge.accessor(Input.getValue, setValueFromJS, .{ .dom_exception = true });
pub const defaultValue = bridge.accessor(Input.getDefaultValue, Input.setDefaultValue, .{}); pub const defaultValue = bridge.accessor(Input.getDefaultValue, Input.setDefaultValue, .{});
pub const checked = bridge.accessor(Input.getChecked, Input.setChecked, .{}); pub const checked = bridge.accessor(Input.getChecked, Input.setChecked, .{});
pub const defaultChecked = bridge.accessor(Input.getDefaultChecked, Input.setDefaultChecked, .{}); pub const defaultChecked = bridge.accessor(Input.getDefaultChecked, Input.setDefaultChecked, .{});