public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1405 from lightpanda-io/prevent_fast_double_navigate

Browse Source 
Handle fast double navigate
This commit is contained in:
Karl Seguin
2026-01-24 07:39:39 +08:00
committed by GitHub
parent 027e569087 23303a759b
commit 3a0699fc1d
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/browser/Page.zig
View File

@@ -256,7 +256,7 @@ fn reset(self: *Page, comptime initializing: bool) !void {
self.window._location = &default_location; self.window._location = &default_location;
self._parse_state = .pre; self._parse_state = .pre;
self._load_state = .parsing; self._load_state = .waiting;
self._queued_navigation = null; self._queued_navigation = null;
self._parse_mode = .document; self._parse_mode = .document;
self._attribute_lookup = .empty; self._attribute_lookup = .empty;
@@ -335,11 +335,12 @@ pub fn isSameOrigin(self: *const Page, url: [:0]const u8) !bool {
pub fn navigate(self: *Page, request_url: [:0]const u8, opts: NavigateOpts) !void { pub fn navigate(self: *Page, request_url: [:0]const u8, opts: NavigateOpts) !void {
const session = self._session; const session = self._session;
if (self._parse_state != .pre) { if (self._parse_state != .pre or self._load_state != .waiting) {
// it's possible for navigate to be called multiple times on the // it's possible for navigate to be called multiple times on the
// same page (via CDP). We want to reset the page between each call. // same page (via CDP). We want to reset the page between each call.
try self.reset(false); try self.reset(false);
} }
self._load_state = .parsing;
const req_id = self._session.browser.http_client.nextReqId(); const req_id = self._session.browser.http_client.nextReqId();
log.info(.page, "navigate", .{ log.info(.page, "navigate", .{
@@ -2710,6 +2711,9 @@ const ParseState = union(enum) {
}; };
const LoadState = enum { const LoadState = enum {
// waiting for the main HTML
waiting,
// the main HTML is being parsed (or downloaded) // the main HTML is being parsed (or downloaded)
parsing, parsing,