From 3c07c0818d12523c11568b862ab74d91f0d8fea3 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Mon, 23 Jun 2025 17:19:30 +0800 Subject: [PATCH] improve variable names --- src/browser/page.zig | 4 ++-- src/runtime/loop.zig | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/browser/page.zig b/src/browser/page.zig index e03fba1d..72733cda 100644 --- a/src/browser/page.zig +++ b/src/browser/page.zig @@ -144,12 +144,12 @@ pub const Page = struct { return self.fetchData("module", src); } - pub fn wait(self: *Page, wait_time: usize) !void { + pub fn wait(self: *Page, wait_ns: usize) !void { var try_catch: Env.TryCatch = undefined; try_catch.init(self.main_context); defer try_catch.deinit(); - try self.session.browser.app.loop.run(wait_time); + try self.session.browser.app.loop.run(wait_ns); if (try_catch.hasCaught() == false) { log.debug(.browser, "page wait complete", .{}); diff --git a/src/runtime/loop.zig b/src/runtime/loop.zig index c90cb69d..46d12763 100644 --- a/src/runtime/loop.zig +++ b/src/runtime/loop.zig @@ -23,6 +23,8 @@ const MemoryPool = std.heap.MemoryPool; const log = @import("../log.zig"); pub const IO = @import("tigerbeetle-io").IO; +const RUN_DURATION = 10 * std.time.ns_per_ms; + // SingleThreaded I/O Loop based on Tigerbeetle io_uring loop. // On Linux it's using io_uring. // On MacOS and Windows it's using kqueue/IOCP with a ring design. @@ -82,7 +84,7 @@ pub const Loop = struct { // run tail events. We do run the tail events to ensure all the // contexts are correcly free. while (self.pending_network_count != 0 or self.pending_timeout_count != 0) { - self.io.run_for_ns(std.time.ns_per_ms * 10) catch |err| { + self.io.run_for_ns(RUN_DURATION) catch |err| { log.err(.loop, "deinit", .{ .err = err }); break; }; @@ -102,12 +104,12 @@ pub const Loop = struct { // Stops when there is no more I/O events registered on the loop. // Note that I/O events callbacks might register more I/O events // on the go when they are executed (ie. nested I/O events). - pub fn run(self: *Self, wait_time: usize) !void { + pub fn run(self: *Self, wait_ns: usize) !void { // stop repeating / interval timeouts from re-registering self.stopping = true; defer self.stopping = false; - const max_iterations = wait_time / (std.time.ns_per_ms * 10); + const max_iterations = wait_ns / (RUN_DURATION); for (0..max_iterations) |_| { if (self.pending_network_count == 0 and self.pending_timeout_count == 0) { break;