From 3f31573bcba2bc03df3d44057dceca3bb4cc0b1f Mon Sep 17 00:00:00 2001
From: sjorsdonkers <72333389+sjorsdonkers@users.noreply.github.com>
Date: Tue, 20 May 2025 12:39:46 +0200
Subject: [PATCH] No need to navigate to about:blank

---
 src/cdp/domains/target.zig | 7 -------
 src/cdp/testing.zig        | 2 +-
 src/testing.zig            | 6 +++---
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/src/cdp/domains/target.zig b/src/cdp/domains/target.zig
index 662deb34..fca78351 100644
--- a/src/cdp/domains/target.zig
+++ b/src/cdp/domains/target.zig
@@ -125,9 +125,6 @@ fn createTarget(cmd: anytype) !void {
     bc.target_id = target_id;
 
     var page = try bc.session.createPage();
-    // Navigate to about:blank such that the window.document are created and set
-    const url = @import("../../url.zig").URL.about_blank;
-    try page.navigate(url, .{});
     {
         const aux_data = try std.fmt.allocPrint(cmd.arena, "{{\"isDefault\":true,\"type\":\"default\",\"frameId\":\"{s}\"}}", .{target_id});
         bc.inspector.contextCreated(
@@ -504,10 +501,6 @@ test "cdp.target: createTarget" {
         // should create a browser context
         const bc = ctx.cdp().browser_context.?;
         try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "about:blank", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
-
-        // Even about:blank should set the window.document
-        const page = ctx.cdp().browser_context.?.session.page.?;
-        try testing.expect(page.window.document != null);
     }
 
     {
diff --git a/src/cdp/testing.zig b/src/cdp/testing.zig
index 7a6a936c..ccb93334 100644
--- a/src/cdp/testing.zig
+++ b/src/cdp/testing.zig
@@ -123,7 +123,7 @@ const TestContext = struct {
             if (bc.session_id == null) bc.session_id = "SID-X";
             parser.deinit();
             const page = try bc.session.createPage();
-            page.doc = (try Document.init(html)).doc;
+            page.window.document = (try Document.init(html)).doc;
         }
         return bc;
     }
diff --git a/src/testing.zig b/src/testing.zig
index c9dc6ecd..7db16d65 100644
--- a/src/testing.zig
+++ b/src/testing.zig
@@ -207,7 +207,7 @@ pub const Random = struct {
 };
 
 pub const Document = struct {
-    doc: *parser.Document,
+    doc: *parser.DocumentHTML,
     arena: std.heap.ArenaAllocator,
 
     pub fn init(html: []const u8) !Document {
@@ -219,7 +219,7 @@ pub const Document = struct {
 
         return .{
             .arena = std.heap.ArenaAllocator.init(allocator),
-            .doc = parser.documentHTMLToDocument(html_doc),
+            .doc = html_doc,
         };
     }
 
@@ -240,7 +240,7 @@ pub const Document = struct {
     }
 
     pub fn asNode(self: *const Document) *parser.Node {
-        return parser.documentToNode(self.doc);
+        return parser.documentHTMLToNode(self.doc);
     }
 };