public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1656 from lightpanda-io/dump_attribute

Browse Source 
Dump Attribute to empty string
This commit is contained in:
Karl Seguin
2026-02-25 18:31:19 +08:00
committed by GitHub
parent f0d6ae2a00 25298a32fa
commit 424dddf67b
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/browser/dump.zig
View File

@@ -172,7 +172,11 @@ fn _deep(node: *Node, opts: Opts, comptime force_slot: bool, writer: *std.Io.Wri
try writer.writeAll(">\n"); try writer.writeAll(">\n");
}, },
.document_fragment => try children(node, opts, writer, page), .document_fragment => try children(node, opts, writer, page),
.attribute => unreachable, .attribute => {
// Not called normally, but can be called via XMLSerializer.serializeToString
// in which case it should return an empty string
try writer.writeAll("");
},
} }
} }

11
src/browser/tests/xmlserializer.html
View File

@@ -129,3 +129,14 @@
testing.expectEqual(original, serialized); testing.expectEqual(original, serialized);
} }
</script> </script>
<script id=serializeAttribute>
{
const div = document.createElement('div');
div.setAttribute('over', '9000');
const serializer = new XMLSerializer();
const serialized = serializer.serializeToString(div.getAttributeNode('over'));
testing.expectEqual('', serialized);
}
</script>