public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

panic instead of unreachable on robots callbacks

Browse Source
This commit is contained in:
Muki Kiboigo
2026-02-09 05:35:32 -08:00
parent 34067a1d70
commit 46c73a05a9
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/http/Client.zig
View File

@@ -386,13 +386,12 @@ fn robotsDoneCallback(ctx_ptr: *anyopaque) !void {
try ctx.client.robot_store.putAbsent(ctx.robots_url); try ctx.client.robot_store.putAbsent(ctx.robots_url);
} }
const queued = ctx.client.pending_robots_queue.getPtr(ctx.robots_url) orelse unreachable; var queued = ctx.client.pending_robots_queue.fetchRemove(
defer { ctx.robots_url,
queued.deinit(ctx.client.allocator); ) orelse @panic("Client.robotsDoneCallbacke empty queue");
_ = ctx.client.pending_robots_queue.remove(ctx.robots_url); defer queued.value.deinit(ctx.client.allocator);
}
for (queued.items) |queued_req| { for (queued.value.items) |queued_req| {
if (!allowed) { if (!allowed) {
log.warn(.http, "blocked by robots", .{ .url = queued_req.url }); log.warn(.http, "blocked by robots", .{ .url = queued_req.url });
queued_req.error_callback(queued_req.ctx, error.RobotsBlocked); queued_req.error_callback(queued_req.ctx, error.RobotsBlocked);
@@ -410,14 +409,13 @@ fn robotsErrorCallback(ctx_ptr: *anyopaque, err: anyerror) void {
log.warn(.http, "robots fetch failed", .{ .err = err }); log.warn(.http, "robots fetch failed", .{ .err = err });
const queued = ctx.client.pending_robots_queue.getPtr(ctx.robots_url) orelse unreachable; var queued = ctx.client.pending_robots_queue.fetchRemove(
defer { ctx.robots_url,
queued.deinit(ctx.client.allocator); ) orelse @panic("Client.robotsErrorCallback empty queue");
_ = ctx.client.pending_robots_queue.remove(ctx.robots_url); defer queued.value.deinit(ctx.client.allocator);
}
// On error, allow all queued requests to proceed // On error, allow all queued requests to proceed
for (queued.items) |queued_req| { for (queued.value.items) |queued_req| {
ctx.client.processRequest(queued_req) catch |e| { ctx.client.processRequest(queued_req) catch |e| {
queued_req.error_callback(queued_req.ctx, e); queued_req.error_callback(queued_req.ctx, e);
}; };