public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

ScriptManager: defer resource handover until request success

Browse Source
This commit is contained in:
Adrià Arrufat
2026-03-17 15:42:52 +09:00
parent e048b0372f
commit 46df341506
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/browser/ScriptManager.zig
View File

@@ -261,7 +261,6 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
break :blk .normal; break :blk .normal;
}, },
}; };
handover = true;
const is_blocking = script.mode == .normal; const is_blocking = script.mode == .normal;
if (is_blocking == false) { if (is_blocking == false) {
@@ -273,7 +272,7 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
if (is_blocking == false) { if (is_blocking == false) {
self.scriptList(script).remove(&script.node); self.scriptList(script).remove(&script.node);
} }
script.deinit(); // Let the outer errdefer handle releasing the arena if client.request fails
} }
try self.client.request(.{ try self.client.request(.{
@@ -292,6 +291,7 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
.done_callback = Script.doneCallback, .done_callback = Script.doneCallback,
.error_callback = Script.errorCallback, .error_callback = Script.errorCallback,
}); });
handover = true;
if (comptime IS_DEBUG) { if (comptime IS_DEBUG) {
var ls: js.Local.Scope = undefined; var ls: js.Local.Scope = undefined;