public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1530 from lightpanda-io/node_contains_null

Browse Source 
Allow node.contains(null) (false), per spec
This commit is contained in:
Pierre Tachoire
2026-02-12 09:48:14 +01:00
committed by GitHub
parent 4dfd357c0b 3d32759030
commit 4813469659
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/browser/tests/node/node.html
View File

@@ -210,3 +210,16 @@
testing.expectEqual('HTMLDivElement', disconnectedChild.getRootNode().__proto__.constructor.name); testing.expectEqual('HTMLDivElement', disconnectedChild.getRootNode().__proto__.constructor.name);
testing.expectEqual('HTMLDivElement', disconnectedChild.getRootNode({ composed: true }).__proto__.constructor.name); testing.expectEqual('HTMLDivElement', disconnectedChild.getRootNode({ composed: true }).__proto__.constructor.name);
</script> </script>
<div id=contains><div id=other></div></div>
<script id=contains>
{
const d1 = $('#contains');
const d2 = $('#other');
testing.expectEqual(false, d1.contains(null));
testing.expectEqual(true, d1.contains(d1));
testing.expectEqual(false, d2.contains(d1));
testing.expectEqual(true, d1.contains(d2));
testing.expectEqual(false, d1.contains(p1));
}
</script>

4
src/browser/webapi/Node.zig
View File

@@ -413,7 +413,9 @@ pub fn getRootNode(self: *Node, opts_: ?GetRootNodeOpts) *Node {
return root; return root;
} }
pub fn contains(self: *const Node, child: *const Node) bool { pub fn contains(self: *const Node, child_: ?*const Node) bool {
const child = child_ orelse return false;
if (self == child) { if (self == child) {
// yes, this is correct // yes, this is correct
return true; return true;