public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1688 from lightpanda-io/cdp_shutdown

Browse Source 
Remove redundant CDP v8 shutdown
This commit is contained in:
Pierre Tachoire
2026-03-02 09:35:40 +01:00
committed by GitHub
parent 2a78c946e4 03b999c592
commit 48d94d0f68
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/cdp/cdp.zig
View File

@@ -438,15 +438,10 @@ pub fn BrowserContext(comptime CDP_T: type) type {
const browser = &self.cdp.browser; const browser = &self.cdp.browser;
const env = &browser.env; const env = &browser.env;
// Drain microtasks makes sure we don't have inspector's callback
// in progress before deinit.
env.runMicrotasks();
// resetContextGroup detach the inspector from all contexts. // resetContextGroup detach the inspector from all contexts.
// It append async tasks, so we make sure we run the message loop // It appends async tasks, so we make sure we run the message loop
// before deinit it. // before deinit it.
env.inspector.?.resetContextGroup(); env.inspector.?.resetContextGroup();
_ = env.pumpMessageLoop();
env.inspector.?.stopSession(); env.inspector.?.stopSession();
// abort all intercepted requests before closing the sesion/page // abort all intercepted requests before closing the sesion/page