From 4b29823a5bb48a220f8cf9531b70d6f2ef953c1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A0=20Arrufat?= <adria.arrufat@gmail.com>
Date: Mon, 23 Mar 2026 13:24:21 +0900
Subject: [PATCH] refactor: simplify form extraction and remove const casts

---
 src/browser/forms.zig  | 6 +++---
 src/cdp/domains/lp.zig | 2 +-
 src/mcp/tools.zig      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/browser/forms.zig b/src/browser/forms.zig
index 67cbd5b5..2619763f 100644
--- a/src/browser/forms.zig
+++ b/src/browser/forms.zig
@@ -48,7 +48,7 @@ pub const FormField = struct {
     required: bool,
     value: ?[]const u8,
     placeholder: ?[]const u8,
-    options: []const SelectOption,
+    options: []SelectOption,
 
     pub fn jsonStringify(self: *const FormField, jw: anytype) !void {
         try jw.beginObject();
@@ -104,7 +104,7 @@ pub const FormInfo = struct {
     node: *Node,
     action: ?[]const u8,
     method: ?[]const u8,
-    fields: []const FormField,
+    fields: []FormField,
 
     pub fn jsonStringify(self: *const FormInfo, jw: anytype) !void {
         try jw.beginObject();
@@ -159,7 +159,7 @@ pub fn collectForms(
         try forms.append(arena, .{
             .node = node,
             .action = if (action_attr) |a| if (a.len > 0) a else null else null,
-            .method = if (method_str.len > 0) method_str else null,
+            .method = method_str,
             .fields = fields,
         });
     }
diff --git a/src/cdp/domains/lp.zig b/src/cdp/domains/lp.zig
index 031e39fd..3944ea40 100644
--- a/src/cdp/domains/lp.zig
+++ b/src/cdp/domains/lp.zig
@@ -176,7 +176,7 @@ fn detectForms(cmd: anytype) !void {
     for (forms_data) |*form| {
         const registered = try bc.node_registry.register(form.node);
         form.backendNodeId = registered.id;
-        for (@constCast(form.fields)) |*field| {
+        for (form.fields) |*field| {
             const field_registered = try bc.node_registry.register(field.node);
             field.backendNodeId = field_registered.id;
         }
diff --git a/src/mcp/tools.zig b/src/mcp/tools.zig
index b7d3f942..c3d8bb71 100644
--- a/src/mcp/tools.zig
+++ b/src/mcp/tools.zig
@@ -475,7 +475,7 @@ fn handleDetectForms(server: *Server, arena: std.mem.Allocator, id: std.json.Val
         const form_registered = try server.node_registry.register(form.node);
         form.backendNodeId = form_registered.id;
 
-        for (@constCast(form.fields)) |*field| {
+        for (form.fields) |*field| {
             const field_registered = try server.node_registry.register(field.node);
             field.backendNodeId = field_registered.id;
         }