From 4c225e515dd1c42eb3a07fbaff485a540d47076f Mon Sep 17 00:00:00 2001
From: Francis Bouvier <francis@lightpanda.io>
Date: Mon, 7 Oct 2024 16:04:29 +0200
Subject: [PATCH] server: let the caller of sendSync free the string

Signed-off-by: Francis Bouvier <francis@lightpanda.io>
---
 src/cdp/cdp.zig    | 1 +
 src/cdp/page.zig   | 1 +
 src/cdp/target.zig | 1 +
 src/server.zig     | 1 -
 4 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/cdp/cdp.zig b/src/cdp/cdp.zig
index 1a60b400..245659cc 100644
--- a/src/cdp/cdp.zig
+++ b/src/cdp/cdp.zig
@@ -207,6 +207,7 @@ pub fn sendEvent(
     const resp = Resp{ .method = name, .params = params, .sessionId = sessionID };
 
     const event_msg = try stringify(alloc, resp);
+    defer alloc.free(event_msg);
     std.log.debug("event {s}", .{event_msg});
     try server.sendSync(ctx, event_msg);
 }
diff --git a/src/cdp/page.zig b/src/cdp/page.zig
index f4d7463e..57591088 100644
--- a/src/cdp/page.zig
+++ b/src/cdp/page.zig
@@ -269,6 +269,7 @@ fn navigate(
         .loaderId = ctx.state.loaderID,
     };
     const res = try result(alloc, id orelse msg.id.?, Resp, resp, msg.sessionID);
+    defer alloc.free(res);
     std.log.debug("res {s}", .{res});
     try server.sendSync(ctx, res);
 
diff --git a/src/cdp/target.zig b/src/cdp/target.zig
index 5c40ce34..0221f0e4 100644
--- a/src/cdp/target.zig
+++ b/src/cdp/target.zig
@@ -308,6 +308,7 @@ fn closeTarget(
         success: bool = true,
     };
     const res = try result(alloc, id orelse msg.id.?, Resp, Resp{}, null);
+    defer alloc.free(res);
     try server.sendSync(ctx, res);
 
     // Inspector.detached event
diff --git a/src/server.zig b/src/server.zig
index 45e40d09..a2249bec 100644
--- a/src/server.zig
+++ b/src/server.zig
@@ -214,7 +214,6 @@ pub fn sendAsync(ctx: *Cmd, msg: []const u8) !void {
 }
 
 pub fn sendSync(ctx: *Cmd, msg: []const u8) !void {
-    defer ctx.alloc().free(msg);
     const s = try std.posix.write(ctx.socket, msg);
     std.log.debug("send sync {d} bytes", .{s});
 }