From 4de6ad02f5d706a19ca10f81ab4ab861f71e7201 Mon Sep 17 00:00:00 2001 From: Francis Bouvier Date: Fri, 29 Sep 2023 13:42:39 +0200 Subject: [PATCH] node: move arg check in API declaration for nodeLookupPrefix method Signed-off-by: Francis Bouvier --- src/dom/node.zig | 6 ++++++ src/netsurf.zig | 10 ++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/dom/node.zig b/src/dom/node.zig index 533f5b92..1ddb9982 100644 --- a/src/dom/node.zig +++ b/src/dom/node.zig @@ -178,6 +178,12 @@ pub const Node = struct { pub fn _lookupPrefix(self: *parser.Node, namespace: ?[]const u8) ?[]const u8 { // TODO: other is not an optional parameter, but can be null. + if (namespace == null) { + return null; + } + if (std.mem.eql(u8, namespace.?, "")) { + return null; + } return parser.nodeLookupPrefix(self, namespace); } diff --git a/src/netsurf.zig b/src/netsurf.zig index 4cf6184b..7ee98dfc 100644 --- a/src/netsurf.zig +++ b/src/netsurf.zig @@ -383,15 +383,9 @@ pub fn nodeIsSameNode(node: *Node, other: *Node) bool { return res; } -pub fn nodeLookupPrefix(node: *Node, namespace: ?[]const u8) ?[]const u8 { - if (namespace == null) { - return null; - } - if (std.mem.eql(u8, namespace.?, "")) { - return null; - } +pub fn nodeLookupPrefix(node: *Node, namespace: []const u8) ?[]const u8 { var s: ?*String = undefined; - _ = nodeVtable(node).dom_node_lookup_prefix.?(node, stringFromData(namespace.?), &s); + _ = nodeVtable(node).dom_node_lookup_prefix.?(node, stringFromData(namespace), &s); if (s == null) { return null; }