public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 06:23:45 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1414 from lightpanda-io/cheak_leak_before_free

Browse Source 
Check for arena pool leak _before_ resetting page arena
This commit is contained in:
Karl Seguin
2026-01-27 08:55:31 +08:00
committed by GitHub
parent adeda6cd75 09665c3a4a
commit 51dca3be11
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/browser/Page.zig
View File

@@ -244,6 +244,14 @@ pub fn deinit(self: *Page) void {
} }
fn reset(self: *Page, comptime initializing: bool) !void { fn reset(self: *Page, comptime initializing: bool) !void {
if (comptime IS_DEBUG) {
var it = self._arena_pool_leak_track.valueIterator();
while (it.next()) |value_ptr| {
log.err(.bug, "ArenaPool Leak", .{ .owner = value_ptr.* });
}
self._arena_pool_leak_track.clearRetainingCapacity();
}
if (comptime initializing == false) { if (comptime initializing == false) {
// Removins the context triggers the linked inspector. // Removins the context triggers the linked inspector.
// It seems to append a collect task to the message loop. // It seems to append a collect task to the message loop.
@@ -326,14 +334,6 @@ fn reset(self: *Page, comptime initializing: bool) !void {
self._undefined_custom_elements = .{}; self._undefined_custom_elements = .{};
try self.registerBackgroundTasks(); try self.registerBackgroundTasks();
if (comptime IS_DEBUG) {
var it = self._arena_pool_leak_track.valueIterator();
while (it.next()) |value_ptr| {
log.err(.bug, "ArenaPool Leak", .{ .owner = value_ptr.* });
}
self._arena_pool_leak_track.clearRetainingCapacity();
}
} }
pub fn base(self: *const Page) [:0]const u8 { pub fn base(self: *const Page) [:0]const u8 {