Merge pull request #2049 from lightpanda-io/refactor/getNodeDetails-param-order
Some checks failed
e2e-test / zig build release (push) Has been cancelled
e2e-test / demo-scripts (push) Has been cancelled
e2e-test / wba-demo-scripts (push) Has been cancelled
e2e-test / wba-test (push) Has been cancelled
e2e-test / cdp-and-hyperfine-bench (push) Has been cancelled
e2e-test / perf-fmt (push) Has been cancelled
e2e-test / browser fetch (push) Has been cancelled
zig-test / zig fmt (push) Has been cancelled
zig-test / zig test using v8 in debug mode (push) Has been cancelled
zig-test / zig test (push) Has been cancelled
zig-test / perf-fmt (push) Has been cancelled

SemanticTree: reorder getNodeDetails params
This commit is contained in:
Adrià Arrufat
2026-03-31 07:58:28 +02:00
committed by GitHub
3 changed files with 3 additions and 3 deletions

View File

@@ -640,10 +640,10 @@ pub const NodeDetails = struct {
}; };
pub fn getNodeDetails( pub fn getNodeDetails(
arena: std.mem.Allocator,
node: *Node, node: *Node,
registry: *CDPNode.Registry, registry: *CDPNode.Registry,
page: *Page, page: *Page,
arena: std.mem.Allocator,
) !NodeDetails { ) !NodeDetails {
const cdp_node = try registry.register(node); const cdp_node = try registry.register(node);
const axn = AXNode.fromNode(node); const axn = AXNode.fromNode(node);

View File

@@ -154,7 +154,7 @@ fn getNodeDetails(cmd: anytype) !void {
const node = (bc.node_registry.lookup_by_id.get(params.backendNodeId) orelse return error.InvalidNodeId).dom; const node = (bc.node_registry.lookup_by_id.get(params.backendNodeId) orelse return error.InvalidNodeId).dom;
const details = SemanticTree.getNodeDetails(node, &bc.node_registry, page, cmd.arena) catch return error.InternalError; const details = SemanticTree.getNodeDetails(cmd.arena, node, &bc.node_registry, page) catch return error.InternalError;
return cmd.sendResult(.{ return cmd.sendResult(.{
.nodeDetails = details, .nodeDetails = details,

View File

@@ -404,7 +404,7 @@ fn handleNodeDetails(server: *Server, arena: std.mem.Allocator, id: std.json.Val
}; };
const page = server.session.currentPage().?; const page = server.session.currentPage().?;
const details = lp.SemanticTree.getNodeDetails(node.dom, &server.node_registry, page, arena) catch { const details = lp.SemanticTree.getNodeDetails(arena, node.dom, &server.node_registry, page) catch {
return server.sendError(id, .InternalError, "Failed to get node details"); return server.sendError(id, .InternalError, "Failed to get node details");
}; };