From 5a40cbd6550a7c655c4918b14a9000218dc669e7 Mon Sep 17 00:00:00 2001
From: Pierre Tachoire <pierre@lightpanda.io>
Date: Tue, 26 Aug 2025 14:26:08 +0200
Subject: [PATCH] cdp: use enum for AuthChallengeResponse

---
 src/cdp/domains/fetch.zig | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/cdp/domains/fetch.zig b/src/cdp/domains/fetch.zig
index d8837c0d..5397cc45 100644
--- a/src/cdp/domains/fetch.zig
+++ b/src/cdp/domains/fetch.zig
@@ -274,12 +274,19 @@ fn continueRequest(cmd: anytype) !void {
     return cmd.sendResult(null, .{});
 }
 
+// https://chromedevtools.github.io/devtools-protocol/tot/Fetch/#type-AuthChallengeResponse
+const AuthChallengeResponse = enum {
+    Default,
+    CancelAuth,
+    ProvideCredentials,
+};
+
 fn continueWithAuth(cmd: anytype) !void {
     const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
     const params = (try cmd.params(struct {
         requestId: []const u8, // "INTERCEPT-{d}"
         authChallengeResponse: struct {
-            response: []const u8,
+            response: AuthChallengeResponse,
             username: []const u8 = "",
             password: []const u8 = "",
         },
@@ -297,7 +304,7 @@ fn continueWithAuth(cmd: anytype) !void {
         .response = params.authChallengeResponse.response,
     });
 
-    if (!std.mem.eql(u8, params.authChallengeResponse.response, "ProvideCredentials")) {
+    if (params.authChallengeResponse.response != .ProvideCredentials) {
         transfer.abortAuthChallenge();
         return cmd.sendResult(null, .{});
     }