public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1879 from lightpanda-io/fix-leak-add-from-element

Browse Source 
ScriptManager: fix memory leak and resource handover
This commit is contained in:
Adrià Arrufat
2026-03-17 16:33:49 +09:00
committed by GitHub
parent 5cc5e513dd 46df341506
commit 5b1056862a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/browser/ScriptManager.zig
View File

@@ -214,6 +214,7 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
if (inline_source.len == 0) { if (inline_source.len == 0) {
// we haven't set script_element._executed = true yet, which is good. // we haven't set script_element._executed = true yet, which is good.
// If content is appended to the script, we will execute it then. // If content is appended to the script, we will execute it then.
page.releaseArena(arena);
return; return;
} }
source = .{ .@"inline" = inline_source }; source = .{ .@"inline" = inline_source };
@@ -271,7 +272,7 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
if (is_blocking == false) { if (is_blocking == false) {
self.scriptList(script).remove(&script.node); self.scriptList(script).remove(&script.node);
} }
script.deinit(); // Let the outer errdefer handle releasing the arena if client.request fails
} }
try self.client.request(.{ try self.client.request(.{