public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-30 17:18:57 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

unregister before releasingRef to avoid potential use-after-free

Browse Source
This commit is contained in:
Karl Seguin
2026-03-30 15:42:08 +08:00
parent 269924090a
commit 5cd356631c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/browser/webapi/IntersectionObserver.zig
View File

@@ -190,11 +190,11 @@ pub fn disconnect(self: *IntersectionObserver, page: *Page) void {
const observing_count = self._observing.items.len; const observing_count = self._observing.items.len;
self._observing.clearRetainingCapacity(); self._observing.clearRetainingCapacity();
page.unregisterIntersectionObserver(self);
if (observing_count > 0) { if (observing_count > 0) {
_ = self.releaseRef(page._session); _ = self.releaseRef(page._session);
} }
page.unregisterIntersectionObserver(self);
} }
pub fn takeRecords(self: *IntersectionObserver, page: *Page) ![]*IntersectionObserverEntry { pub fn takeRecords(self: *IntersectionObserver, page: *Page) ![]*IntersectionObserverEntry {