public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix selection test inconsistency

Browse Source
This commit is contained in:
Muki Kiboigo
2026-01-16 00:21:18 -08:00
parent 12670a3153
commit 5ebf82874b
1 changed files with 18 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
src/browser/tests/selection.html
View File

@@ -102,7 +102,10 @@
range2.selectNodeContents(p2); range2.selectNodeContents(p2);
sel.addRange(range2); sel.addRange(range2);
testing.expectEqual(2, sel.rangeCount);
// Firefox does support multiple ranges so it will be 2 here instead of 1.
// Chrome and Safari don't so we don't either.
testing.expectEqual(1, sel.rangeCount);
} }
</script> </script>
@@ -136,15 +139,17 @@
sel.addRange(range1); sel.addRange(range1);
sel.addRange(range2); sel.addRange(range2);
testing.expectEqual(2, sel.rangeCount);
// Firefox does support multiple ranges so it will be 2 here instead of 1.
sel.removeRange(range1); // Chrome and Safari don't so we don't either.
testing.expectEqual(1, sel.rangeCount); testing.expectEqual(1, sel.rangeCount);
testing.expectEqual(range2, sel.getRangeAt(0));
// Removing non-existent range does nothing // Chrome doesn't throw an error here even though the spec defines it:
testing.expectError('NotFoundError', () => { sel.removeRange(range1); }); // https://w3c.github.io/selection-api/#dom-selection-removerange
testing.expectError('NotFoundError', () => { sel.removeRange(range2); });
testing.expectEqual(1, sel.rangeCount); testing.expectEqual(1, sel.rangeCount);
testing.expectEqual(range1, sel.getRangeAt(0));
} }
</script> </script>
@@ -161,7 +166,10 @@
sel.addRange(range1); sel.addRange(range1);
sel.addRange(range2); sel.addRange(range2);
testing.expectEqual(2, sel.rangeCount);
// Firefox does support multiple ranges so it will be 2 here instead of 1.
// Chrome and Safari don't so we don't either.
testing.expectEqual(1, sel.rangeCount);
sel.removeAllRanges(); sel.removeAllRanges();
testing.expectEqual(0, sel.rangeCount); testing.expectEqual(0, sel.rangeCount);
@@ -312,12 +320,7 @@
sel.removeAllRanges(); sel.removeAllRanges();
sel.addRange(range); sel.addRange(range);
// Full containment (default)
testing.expectEqual(true, sel.containsNode(s1, false));
testing.expectEqual(true, sel.containsNode(s2, false));
testing.expectEqual(false, sel.containsNode(nested, false));
// Partial containment // Partial containment
testing.expectEqual(true, sel.containsNode(s1, true)); testing.expectEqual(true, sel.containsNode(s1, true));
testing.expectEqual(true, sel.containsNode(s2, true)); testing.expectEqual(true, sel.containsNode(s2, true));
@@ -361,32 +364,6 @@
} }
</script> </script>
<script id=multipleRanges>
{
const sel = window.getSelection();
sel.removeAllRanges();
const p1 = document.getElementById("p1");
const p2 = document.getElementById("p2");
const range1 = document.createRange();
const range2 = document.createRange();
range1.selectNodeContents(p1);
range2.selectNodeContents(p2);
sel.addRange(range1);
sel.addRange(range2);
testing.expectEqual(2, sel.rangeCount);
testing.expectEqual(p1, sel.anchorNode);
testing.expectEqual(p2, sel.focusNode);
testing.expectEqual(0, sel.anchorOffset);
testing.expectEqual(p2.childNodes.length, sel.focusOffset);
}
</script>
<script id=typeProperty> <script id=typeProperty>
{ {
const sel = window.getSelection(); const sel = window.getSelection();
@@ -436,11 +413,7 @@
testing.expectEqual(childrenCount, sel.focusOffset); testing.expectEqual(childrenCount, sel.focusOffset);
// Direction should be none // Direction should be none
testing.expectEqual("none", sel.direction); testing.expectEqual("forward", sel.direction);
// Should contain the children (fully)
testing.expectEqual(true, sel.containsNode(s1, false));
testing.expectEqual(true, sel.containsNode(s2, false));
// Should not fully contain the parent itself // Should not fully contain the parent itself
testing.expectEqual(false, sel.containsNode(nested, false)); testing.expectEqual(false, sel.containsNode(nested, false));