From 4fa542bc38813b21a426cde4adedccf754d2012c Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 14 Aug 2025 17:51:40 +0800 Subject: [PATCH 1/3] fix memory leak --- src/browser/ScriptManager.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/ScriptManager.zig b/src/browser/ScriptManager.zig index 3d5b86bd..e8d91bad 100644 --- a/src/browser/ScriptManager.zig +++ b/src/browser/ScriptManager.zig @@ -230,7 +230,7 @@ pub fn addFromElement(self: *ScriptManager, element: *parser.Element) !void { errdefer pending_script.deinit(); var headers = try HttpClient.Headers.init(); - try page.requestCookie(.{}).headersForRequest(self.allocator, remote_url.?, &headers); + try page.requestCookie(.{}).headersForRequest(page.arena, remote_url.?, &headers); try self.client.request(.{ .url = remote_url.?, From f9352e26cb0bc0c8904c0f3217ffda09df14ec11 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 14 Aug 2025 18:00:56 +0800 Subject: [PATCH 2/3] same memory leak, different place --- src/browser/ScriptManager.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/ScriptManager.zig b/src/browser/ScriptManager.zig index e8d91bad..b9cf01fd 100644 --- a/src/browser/ScriptManager.zig +++ b/src/browser/ScriptManager.zig @@ -297,7 +297,7 @@ pub fn blockingGet(self: *ScriptManager, url: [:0]const u8) !BlockingResult { }; var headers = try HttpClient.Headers.init(); - try self.page.requestCookie(.{}).headersForRequest(self.allocator, url, &headers); + try self.page.requestCookie(.{}).headersForRequest(page.arena, url, &headers); var client = self.client; try client.blockingRequest(.{ From 31f3c2771aeb6505cc06f4421d0b600a9b22912d Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 14 Aug 2025 18:07:14 +0800 Subject: [PATCH 3/3] fix build error...sorry --- src/browser/ScriptManager.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/ScriptManager.zig b/src/browser/ScriptManager.zig index b9cf01fd..d637418c 100644 --- a/src/browser/ScriptManager.zig +++ b/src/browser/ScriptManager.zig @@ -297,7 +297,7 @@ pub fn blockingGet(self: *ScriptManager, url: [:0]const u8) !BlockingResult { }; var headers = try HttpClient.Headers.init(); - try self.page.requestCookie(.{}).headersForRequest(page.arena, url, &headers); + try self.page.requestCookie(.{}).headersForRequest(self.page.arena, url, &headers); var client = self.client; try client.blockingRequest(.{