public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-04-03 16:10:29 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

browser: simplify Runner wait timeout logic

Browse Source
This commit is contained in:
Adrià Arrufat
2026-04-02 14:15:15 +02:00
parent 1770dc03e3
commit 69e5478dd7
1 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/browser/Runner.zig
View File

@@ -68,7 +68,6 @@ pub fn waitCDP(self: *Runner, opts: WaitOpts) !CDPWaitResult {
fn _wait(self: *Runner, comptime is_cdp: bool, opts: WaitOpts) !CDPWaitResult { fn _wait(self: *Runner, comptime is_cdp: bool, opts: WaitOpts) !CDPWaitResult {
var timer = try std.time.Timer.start(); var timer = try std.time.Timer.start();
var ms_remaining = opts.ms;
const tick_opts = TickOpts{ const tick_opts = TickOpts{
.ms = 200, .ms = 200,
@@ -92,22 +91,10 @@ fn _wait(self: *Runner, comptime is_cdp: bool, opts: WaitOpts) !CDPWaitResult {
.cdp_socket => if (comptime is_cdp) return .cdp_socket else unreachable, .cdp_socket => if (comptime is_cdp) return .cdp_socket else unreachable,
}; };
const ms_elapsed = timer.lap() / 1_000_000; const ms_elapsed: u32 = @intCast(timer.read() / std.time.ns_per_ms);
if (ms_elapsed >= ms_remaining) { if (ms_elapsed >= opts.ms) {
// Don't timeout if there's still active work (HTTP requests,
// intercepted requests, background JS tasks, or pending macrotasks).
if (self.http_client.active > 0 or self.http_client.intercepted > 0) {
ms_remaining = opts.ms;
continue;
}
const browser = self.session.browser;
if (browser.hasBackgroundTasks() or browser.msToNextMacrotask() != null) {
ms_remaining = opts.ms;
continue;
}
return error.Timeout; return error.Timeout;
} }
ms_remaining -= @intCast(ms_elapsed);
if (next_ms > 0) { if (next_ms > 0) {
std.Thread.sleep(std.time.ns_per_ms * next_ms); std.Thread.sleep(std.time.ns_per_ms * next_ms);
} }