public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

xhr: defer event destroy

Browse Source
This commit is contained in:
Pierre Tachoire
2024-02-09 11:43:37 +01:00
parent e79933990d
commit 6aa182c131
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/xhr/xhr.zig
View File

@@ -318,6 +318,10 @@ pub const XMLHttpRequest = struct {
const evt = parser.eventCreate() catch |e| {
return log.err("dispatch event create: {any}", .{e});
};
// We can we defer event destroy once the event is dispatched.
defer parser.eventDestroy(evt);
parser.eventInit(evt, typ, .{ .bubbles = true, .cancelable = true }) catch |e| {
return log.err("dispatch event init: {any}", .{e});
};
@@ -331,24 +335,19 @@ pub const XMLHttpRequest = struct {
typ: []const u8,
opts: ProgressEvent.EventInit,
) void {
// TODO destroy struct
const evt = self.alloc.create(ProgressEvent) catch |e| {
return log.err("allocate progress event: {any}", .{e});
};
evt.* = ProgressEvent.constructor(typ, .{
var evt = ProgressEvent.constructor(typ, .{
// https://xhr.spec.whatwg.org/#firing-events-using-the-progressevent-interface
.lengthComputable = opts.total > 0,
.total = opts.total,
.loaded = opts.loaded,
}) catch |e| {
self.alloc.destroy(evt);
return log.err("construct progress event: {any}", .{e});
};
_ = parser.eventTargetDispatchEvent(
@as(*parser.EventTarget, @ptrCast(self)),
@as(*parser.Event, @ptrCast(evt)),
@as(*parser.Event, @ptrCast(&evt)),
) catch |e| {
self.alloc.destroy(evt);
return log.err("dispatch progress event: {any}", .{e});
};
}