public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1715 from lightpanda-io/cdp-frame-navigate

Browse Source 
cdp: don't dispatch executionContextsCleared on frame navigation
This commit is contained in:
Karl Seguin
2026-03-04 22:02:30 +08:00
committed by GitHub
parent f0be6675e7 6a8174a15c
commit 6c5efe6ce0
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/cdp/domains/page.zig
View File

@@ -379,13 +379,22 @@ pub fn pageNavigated(arena: Allocator, bc: anytype, event: *const Notification.P
}, .{ .session_id = session_id }); }, .{ .session_id = session_id });
} }
// When we actually recreated the context we should have the inspector send this event, see: resetContextGroup const page = bc.session.currentPage() orelse return error.PageNotLoaded;
// Sending this event will tell the client that the context ids they had are invalid and the context shouls be dropped
// The client will expect us to send new contextCreated events, such that the client has new id's for the active contexts. // When we actually recreated the context we should have the inspector send
try cdp.sendEvent("Runtime.executionContextsCleared", null, .{ .session_id = session_id }); // this event, see: resetContextGroup Sending this event will tell the
// client that the context ids they had are invalid and the context shouls
// be dropped The client will expect us to send new contextCreated events,
// such that the client has new id's for the active contexts.
// Only send executionContextsCleared for main frame navigations. For child
// frames (iframes), clearing all contexts would destroy the main frame's
// context, causing Puppeteer's page.evaluate()/page.content() to hang
// forever.
if (event.frame_id == page._frame_id) {
try cdp.sendEvent("Runtime.executionContextsCleared", null, .{ .session_id = session_id });
}
{ {
const page = bc.session.currentPage() orelse return error.PageNotLoaded;
const aux_data = try std.fmt.allocPrint(arena, "{{\"isDefault\":true,\"type\":\"default\",\"frameId\":\"{s}\",\"loaderId\":\"{s}\"}}", .{ frame_id, loader_id }); const aux_data = try std.fmt.allocPrint(arena, "{{\"isDefault\":true,\"type\":\"default\",\"frameId\":\"{s}\",\"loaderId\":\"{s}\"}}", .{ frame_id, loader_id });
var ls: js.Local.Scope = undefined; var ls: js.Local.Scope = undefined;