From 1bd1f123a3a9aa7549faae5f86cf52e51680ff2b Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Wed, 10 Sep 2025 16:25:58 +0800 Subject: [PATCH 1/2] Upgrade v8 Depends on https://github.com/lightpanda-io/zig-v8-fork/pull/93 --- build.zig.zon | 6 +++--- src/runtime/test_object_types.zig | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/build.zig.zon b/build.zig.zon index 5acbf006..396c8ce9 100644 --- a/build.zig.zon +++ b/build.zig.zon @@ -5,9 +5,9 @@ .fingerprint = 0xda130f3af836cea0, .dependencies = .{ .v8 = .{ - .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/d3040a953e5a37290dae20e7ddf138b7aeb5e67d.tar.gz", - .hash = "v8-0.0.0-xddH6w_EAwA8vK0NAxfxfI7IcbnpkUAcXKNujn7qwnmY", + .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/bad207becebbf3760b80714277002f6fc2ac2d7b.tar.gz", + .hash = "v8-0.0.0-xddH6-PBAwD-PIIBTMgUv9ZfAMyCfGeXg61moiNN4qwV", }, - //.v8 = .{ .path = "../zig-v8-fork" } + // .v8 = .{ .path = "../zig-v8-fork" } }, } diff --git a/src/runtime/test_object_types.zig b/src/runtime/test_object_types.zig index ebf750f4..a1b6a474 100644 --- a/src/runtime/test_object_types.zig +++ b/src/runtime/test_object_types.zig @@ -210,8 +210,8 @@ test "JS: object types" { defer runner.deinit(); - // v8 has 5 default "own" properties - const own_base = "5"; + // v8 has 3 default "own" properties + const own_base = "3"; try runner.testCases(&.{ .{ "Object.getOwnPropertyNames(MyObject).length;", own_base }, From 9092d1f8eb6f51ae07baa1337877e75876e5d459 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Fri, 12 Sep 2025 07:53:18 +0800 Subject: [PATCH 2/2] update v8 deps --- .github/actions/install/action.yml | 4 ++-- Dockerfile | 4 ++-- build.zig.zon | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/actions/install/action.yml b/.github/actions/install/action.yml index 7b0e5a1c..4ce2adfc 100644 --- a/.github/actions/install/action.yml +++ b/.github/actions/install/action.yml @@ -17,11 +17,11 @@ inputs: zig-v8: description: 'zig v8 version to install' required: false - default: 'v0.1.28' + default: 'v0.1.30' v8: description: 'v8 version to install' required: false - default: '13.6.233.8' + default: '14.0.365.4' cache-dir: description: 'cache dir to use' required: false diff --git a/Dockerfile b/Dockerfile index d4d9dd5a..fc0145af 100644 --- a/Dockerfile +++ b/Dockerfile @@ -3,8 +3,8 @@ FROM debian:stable ARG MINISIG=0.12 ARG ZIG=0.15.1 ARG ZIG_MINISIG=RWSGOq2NVecA2UPNdBUZykf1CCb147pkmdtYxgb3Ti+JO/wCYvhbAb/U -ARG V8=13.6.233.8 -ARG ZIG_V8=v0.1.28 +ARG V8=14.0.365.4 +ARG ZIG_V8=v0.1.30 ARG TARGETPLATFORM RUN apt-get update -yq && \ diff --git a/build.zig.zon b/build.zig.zon index 396c8ce9..ff74c561 100644 --- a/build.zig.zon +++ b/build.zig.zon @@ -5,8 +5,8 @@ .fingerprint = 0xda130f3af836cea0, .dependencies = .{ .v8 = .{ - .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/bad207becebbf3760b80714277002f6fc2ac2d7b.tar.gz", - .hash = "v8-0.0.0-xddH6-PBAwD-PIIBTMgUv9ZfAMyCfGeXg61moiNN4qwV", + .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/7177ee1ae267a44751a0e7e012e257177699a375.tar.gz", + .hash = "v8-0.0.0-xddH63TCAwC1D1hEiOtbEnLBbtz9ZPHrdiGWLcBcYQB7", }, // .v8 = .{ .path = "../zig-v8-fork" } },