public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1319 from lightpanda-io/script_list_cleanup

Browse Source 
Handle immediate call to Script.errorCallback
This commit is contained in:
Karl Seguin
2026-01-06 17:22:14 +08:00
committed by GitHub
parent 7ba34af884 a845b2e35e
commit 6f72eeae65
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/browser/ScriptManager.zig
View File

@@ -239,8 +239,17 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
}; };
const is_blocking = script.mode == .normal; const is_blocking = script.mode == .normal;
if (is_blocking == false) {
self.scriptList(script).append(&script.node);
}
if (remote_url) |url| { if (remote_url) |url| {
errdefer script.deinit(true); errdefer {
if (is_blocking == false) {
self.scriptList(script).remove(&script.node);
}
script.deinit(true);
}
var headers = try self.client.newHeaders(); var headers = try self.client.newHeaders();
try page.requestCookie(.{}).headersForRequest(page.arena, url, &headers); try page.requestCookie(.{}).headersForRequest(page.arena, url, &headers);
@@ -271,8 +280,6 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
} }
if (is_blocking == false) { if (is_blocking == false) {
const list = self.scriptList(script);
list.append(&script.node);
return; return;
} }