From b698e2d078584b23cc969e376bd9b3b34a439d0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Arrufat?= Date: Tue, 17 Mar 2026 13:42:35 +0900 Subject: [PATCH] LogFilter: init with slice and silence tests --- src/browser/Page.zig | 5 ++++- src/cdp/domains/page.zig | 2 +- src/mcp/router.zig | 2 +- src/testing.zig | 8 ++++---- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/browser/Page.zig b/src/browser/Page.zig index b82ca41d..a6757763 100644 --- a/src/browser/Page.zig +++ b/src/browser/Page.zig @@ -3522,13 +3522,16 @@ fn asUint(comptime string: anytype) std.meta.Int( const testing = @import("../testing.zig"); test "WebApi: Page" { - const filter: testing.LogFilter = .init(.http); + const filter: testing.LogFilter = .init(&.{ .http, .js }); defer filter.deinit(); try testing.htmlRunner("page", .{}); } test "WebApi: Frames" { + const filter: testing.LogFilter = .init(&.{.js}); + defer filter.deinit(); + try testing.htmlRunner("frames", .{}); } diff --git a/src/cdp/domains/page.zig b/src/cdp/domains/page.zig index fe21fcca..f40d54a8 100644 --- a/src/cdp/domains/page.zig +++ b/src/cdp/domains/page.zig @@ -663,7 +663,7 @@ test "cdp.page: getFrameTree" { test "cdp.page: captureScreenshot" { const LogFilter = @import("../../testing.zig").LogFilter; - const filter: LogFilter = .init(.not_implemented); + const filter: LogFilter = .init(&.{.not_implemented}); defer filter.deinit(); var ctx = testing.context(); diff --git a/src/mcp/router.zig b/src/mcp/router.zig index 70411814..1bc02624 100644 --- a/src/mcp/router.zig +++ b/src/mcp/router.zig @@ -148,7 +148,7 @@ test "MCP.router - handleMessage - synchronous unit tests" { // 5. Parse error { - const filter: testing.LogFilter = .init(.mcp); + const filter: testing.LogFilter = .init(&.{.mcp}); defer filter.deinit(); try handleMessage(server, aa, "invalid json"); diff --git a/src/testing.zig b/src/testing.zig index f30dbae5..adebdc32 100644 --- a/src/testing.zig +++ b/src/testing.zig @@ -616,12 +616,12 @@ fn testHTTPHandler(req: *std.http.Server.Request) !void { pub const LogFilter = struct { old_filter: []const log.Scope, - /// Sets the log filter to only include the specified scope. + /// Sets the log filter to suppress the specified scope(s). /// Returns a LogFilter that should be deinitialized to restore previous filters. - pub fn init(comptime scope: log.Scope) LogFilter { + pub fn init(comptime scopes: []const log.Scope) LogFilter { + comptime std.debug.assert(@TypeOf(scopes) == []const log.Scope); const old_filter = log.opts.filter_scopes; - const new_filter = comptime &[_]log.Scope{scope}; - log.opts.filter_scopes = new_filter; + log.opts.filter_scopes = scopes; return .{ .old_filter = old_filter }; }