public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-28 22:53:28 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #1150 from lightpanda-io/isdone-async
Some checks failed
e2e-test / zig build release (push) Has been cancelled
Details
e2e-test / demo-scripts (push) Has been cancelled
Details
e2e-test / cdp-and-hyperfine-bench (push) Has been cancelled
Details
e2e-test / perf-fmt (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / browser fetch (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details

Browse Source 
isDone must be run after script's deinit
This commit is contained in:
Karl Seguin
2025-10-15 15:58:42 +08:00
committed by GitHub
parent 18c851e53f 41f4533bc0
commit 73da04bea2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/browser/ScriptManager.zig
View File

@@ -602,8 +602,9 @@ pub const PendingScript = struct {
return; return;
} }
// async script can be evaluated immediately // async script can be evaluated immediately
defer self.deinit();
self.script.eval(manager.page); self.script.eval(manager.page);
self.deinit();
// asyncScriptIsDone must be run after the pending script is deinit.
manager.asyncScriptIsDone(); manager.asyncScriptIsDone();
} }